revert: web/flow: cleanup WebAuthn helper functions (#14460)"#15172
Merged
revert: web/flow: cleanup WebAuthn helper functions (#14460)"#15172
Conversation
This reverts commit e86c40a. Signed-off-by: Jens Langhammer <jens@goauthentik.io> # Conflicts: # web/package-lock.json
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
gergosimonyi
approved these changes
Jun 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15172 +/- ##
=======================================
Coverage 92.79% 92.80%
=======================================
Files 822 822
Lines 42374 42384 +10
=======================================
+ Hits 39323 39334 +11
+ Misses 3051 3050 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-0661a5f827d5bc9c68ccf4d4a8fc76fb424de7ef
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-0661a5f827d5bc9c68ccf4d4a8fc76fb424de7efAfterwards, run the upgrade commands from the latest release notes. |
cavefire
pushed a commit
to cavefire/authentik
that referenced
this pull request
Jun 24, 2025
…" (goauthentik#15172) Revert "web/flow: cleanup WebAuthn helper functions (goauthentik#14460)" This reverts commit e86c40a. Signed-off-by: Jens Langhammer <jens@goauthentik.io> # Conflicts: # web/package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e86c40a.
Signed-off-by: Jens Langhammer jens@goauthentik.io
Conflicts:
web/package-lock.json
Details
While the Original PR included a polyfill for browsers, it seems that various password manager extensions don't implement toJSON correctly or at all which causes things to break. There's also issues on firefox
See aws-samples/amazon-cognito-passwordless-auth#94
See bitwarden/clients#12060
Revert for now as the previous method still worked just fine.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)