Skip to content

providers/oauth2: bug fixes from conformance testing#15056

Merged
BeryJu merged 4 commits intomainfrom
providers/oauth2/better-conformance
Jun 16, 2025
Merged

providers/oauth2: bug fixes from conformance testing#15056
BeryJu merged 4 commits intomainfrom
providers/oauth2/better-conformance

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jun 16, 2025

Details

Bugfixes found from conformance testing


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner June 16, 2025 01:06
@netlify
Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit bc8ff10
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/684f6e4ea93ae400080ec740
😎 Deploy Preview https://deploy-preview-15056--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

BeryJu added 4 commits June 16, 2025 03:07
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
…e id_token

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>

# Conflicts:
#	tests/openid_conformance/test_conformance.py
@BeryJu BeryJu force-pushed the providers/oauth2/better-conformance branch from ec84e6e to bc8ff10 Compare June 16, 2025 01:07
@netlify
Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit ec84e6e
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/684f6e015ea3c1000833d041
😎 Deploy Preview https://deploy-preview-15056--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for authentik-docs failed. Why did it fail? →

Name Link
🔨 Latest commit bc8ff10
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/684f6e4ed99ec90008a0b7a5

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.82%. Comparing base (20e0748) to head (bc8ff10).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15056      +/-   ##
==========================================
+ Coverage   92.76%   92.82%   +0.06%     
==========================================
  Files         815      815              
  Lines       42122    42122              
==========================================
+ Hits        39073    39101      +28     
+ Misses       3049     3021      -28     
Flag Coverage Δ
e2e 47.72% <100.00%> (+0.13%) ⬆️
integration 24.35% <0.00%> (+<0.01%) ⬆️
unit 90.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-bc8ff10d42fa42fa8393fc45f1567ad2bdb33ff3
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-bc8ff10d42fa42fa8393fc45f1567ad2bdb33ff3

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 59a8042 into main Jun 16, 2025
98 of 102 checks passed
@BeryJu BeryJu deleted the providers/oauth2/better-conformance branch June 16, 2025 10:23
kensternberg-authentik added a commit that referenced this pull request Jun 16, 2025
* main: (43 commits)
  Web/cleanup/empty state better slot handling (#14289)
  website/docs: release notes for `2025.6.2` (#15065)
  website/docs: remove commented out config options (#15064)
  website/docs: postgres troubleshooting: get PGPASSWORD from POSTGRES_PASSWORD_FILE (#15039)
  core: bump goauthentik/fips-python from 3.13.4-slim-bookworm-fips to 3.13.5-slim-bookworm-fips (#15058)
  website: bump the eslint group in /website with 2 updates (#15059)
  web: bump the wdio group across 1 directory with 3 updates (#14593)
  web: bump @sentry/browser from 9.28.1 to 9.29.0 in /web in the sentry group across 1 directory (#15061)
  web: bump the eslint group across 2 directories with 2 updates (#15062)
  core: bump axllent/mailpit from v1.26.0 to v1.26.1 in /tests/e2e (#15060)
  core: bump pydantic from 2.11.5 to 2.11.7 (#15063)
  providers/oauth2: bug fixes from conformance testing (#15056)
  website/integrations: change nextcloud scope name to avoid confusion (#15050)
  web/flow: cleanup WebAuthn helper functions (#14460)
  web/elements: fix typo in localeComparator (#15054)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#15049)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in es (#15047)
  core, web: update translations (#15048)
  blueprints: add section support for organisation (#15045)
  core, web: update translations (#15043)
  ...
cavefire pushed a commit to cavefire/authentik that referenced this pull request Jun 24, 2025
* check authorize request param earlier

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix basic suite?

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* another actual fix; don't return access_token when using response_type id_token

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* only run basic+implicit for now, fix other tests

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

# Conflicts:
#	tests/openid_conformance/test_conformance.py

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant