Skip to content

stages/authenticator_email: Fix Enroll dropdown in the MFA Devices page#13404

Merged
BeryJu merged 1 commit intomainfrom
stages/authenticator_email/fix_enroll
Mar 6, 2025
Merged

stages/authenticator_email: Fix Enroll dropdown in the MFA Devices page#13404
BeryJu merged 1 commit intomainfrom
stages/authenticator_email/fix_enroll

Conversation

@melizeche
Copy link
Member

Details

Implements ui_user_settings() method for the Email Authenticator stage, making it available in the MFA enrollment dropdown on the user settings page.

image

closes #13230


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@melizeche melizeche requested a review from a team as a code owner March 5, 2025 22:57
@netlify
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit ccc4bab
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67c8d6c9e1212c00080c8da5

@netlify
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit ccc4bab
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67c8d6c9d9bfc10008881492

@BeryJu
Copy link
Member

BeryJu commented Mar 5, 2025

/cherry-pick version-2025.2

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like brain surgery. I'm impressed that that's all it takes to trigger its appearance on the front-end.

@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (a07ce35) to head (ccc4bab).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13404      +/-   ##
==========================================
- Coverage   92.68%   92.68%   -0.01%     
==========================================
  Files         793      793              
  Lines       40347    40350       +3     
==========================================
+ Hits        37395    37397       +2     
- Misses       2952     2953       +1     
Flag Coverage Δ
e2e 47.91% <66.66%> (-0.01%) ⬇️
integration 24.08% <66.66%> (+<0.01%) ⬆️
unit 90.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ccc4bab0bfef9740ebfda709db304a0b1f666da2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ccc4bab0bfef9740ebfda709db304a0b1f666da2

Afterwards, run the upgrade commands from the latest release notes.

@notion-workspace
Copy link

@BeryJu BeryJu merged commit f6b0eec into main Mar 6, 2025
91 checks passed
@BeryJu BeryJu deleted the stages/authenticator_email/fix_enroll branch March 6, 2025 12:15
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 6, 2025
…ge (#13404)

Implement missing ui_user_settings() in AuthenticatorEmailStage
BeryJu pushed a commit that referenced this pull request Mar 6, 2025
…ge (cherry-pick #13404) (#13414)

stages/authenticator_email: Fix Enroll dropdown in the MFA Devices page (#13404)

Implement missing ui_user_settings() in AuthenticatorEmailStage

Co-authored-by: Marcelo Elizeche Landó <marcelo@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Mar 7, 2025
* main:
  website: add a better edit this page element (#13391)
  web/admin: allow user lists to show active only (#13403)
  core: Tidy contributor onboarding, fix typos. (#12700)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#13418)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#13417)
  lib/config: fix conn_max_age parsing (#13370)
  core: bump golang.org/x/sync from 0.11.0 to 0.12.0 (#13407)
  stages/authenticator_email: Fix Enroll dropdown in the MFA Devices page (#13404)
  core: bump golang.org/x/oauth2 from 0.27.0 to 0.28.0 (#13408)
  core: bump aws-cdk-lib from 2.181.1 to 2.182.0 (#13409)
  core: bump google-api-python-client from 2.162.0 to 2.163.0 (#13410)
  core: bump msgraph-sdk from 1.22.0 to 1.23.0 (#13411)
  core: bump jinja2 from 3.1.5 to 3.1.6 (#13412)
  web/user: ensure modal container on user-settings page is min-height: 100% (#13402)
  core, web: update translations (#13405)
  web/admin: add button to clear application cache (#13399)
  blueprints: Adjust title for MFA set up (#13400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email authentification doesn't add a settings entry

3 participants