core: Tidy contributor onboarding, fix typos.#12700
Merged
GirlBossRush merged 1 commit intogoauthentik:mainfrom Mar 6, 2025
Merged
core: Tidy contributor onboarding, fix typos.#12700GirlBossRush merged 1 commit intogoauthentik:mainfrom
GirlBossRush merged 1 commit intogoauthentik:mainfrom
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12700 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 793 793
Lines 40364 40364
=======================================
Hits 37438 37438
Misses 2926 2926
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rissson
requested changes
Jan 16, 2025
fe330fd to
10893ee
Compare
GirlBossRush
commented
Jan 16, 2025
rissson
requested changes
Jan 20, 2025
rissson
reviewed
Jan 20, 2025
tanberry
reviewed
Jan 27, 2025
Contributor
tanberry
left a comment
There was a problem hiding this comment.
I can't say one way or the other on the code, but thanks for catching the misspellings!!
f69153f to
1f6466d
Compare
rissson
requested changes
Jan 29, 2025
Member
rissson
left a comment
There was a problem hiding this comment.
One more little thing I didn't catch previously, mb
1f6466d to
908679d
Compare
rissson
approved these changes
Jan 30, 2025
rissson
approved these changes
Feb 12, 2025
cc71c25 to
8a3675f
Compare
Contributor
Author
|
@BeryJu Rebased to latest main and ready for review 😁 |
rissson
approved these changes
Mar 5, 2025
BeryJu
reviewed
Mar 6, 2025
Member
BeryJu
left a comment
There was a problem hiding this comment.
Need to verify if we need a redirect for schema.yml on the website repo
Need to check if we need to update any docs that directly run the ak executable to add a poetry run prefix
GirlBossRush
commented
Mar 6, 2025
8a3675f to
9ba0387
Compare
BeryJu
approved these changes
Mar 6, 2025
- Fixes typos. - Fixes stale links. - Tidies Makefile so that Poetry env is optional for hygiene commands. - Remove mismatched YAML naming. - Uses shebang on Python scripts. - Document semver usage. - Redirect OpenAPI schema.
9ba0387 to
6905f09
Compare
kensternberg-authentik
added a commit
that referenced
this pull request
Mar 7, 2025
* main: website: add a better edit this page element (#13391) web/admin: allow user lists to show active only (#13403) core: Tidy contributor onboarding, fix typos. (#12700) translate: Updates for file web/xliff/en.xlf in zh-Hans (#13418) translate: Updates for file web/xliff/en.xlf in zh_CN (#13417) lib/config: fix conn_max_age parsing (#13370) core: bump golang.org/x/sync from 0.11.0 to 0.12.0 (#13407) stages/authenticator_email: Fix Enroll dropdown in the MFA Devices page (#13404) core: bump golang.org/x/oauth2 from 0.27.0 to 0.28.0 (#13408) core: bump aws-cdk-lib from 2.181.1 to 2.182.0 (#13409) core: bump google-api-python-client from 2.162.0 to 2.163.0 (#13410) core: bump msgraph-sdk from 1.22.0 to 1.23.0 (#13411) core: bump jinja2 from 3.1.5 to 3.1.6 (#13412) web/user: ensure modal container on user-settings page is min-height: 100% (#13402) core, web: update translations (#13405) web/admin: add button to clear application cache (#13399) blueprints: Adjust title for MFA set up (#13400)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR contains a subset of fixes discovered when progressing through the authentik contributor guide. Highlights include:
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)