[VisualStudio] ASP.NET Core - bower - default config#2307
Merged
shiftkey merged 2 commits intogithub:masterfrom Nov 23, 2018
Merged
[VisualStudio] ASP.NET Core - bower - default config#2307shiftkey merged 2 commits intogithub:masterfrom
shiftkey merged 2 commits intogithub:masterfrom
Conversation
In VS15 (2017) the default .bowerrc repoints the default location to wwwroot/lib, and bower package restore is ON.
shiftkey
reviewed
Mar 2, 2017
| #bower_components/ | ||
|
|
||
| # VS15: by default bower location is moved, bower restore is true | ||
| **/wwwroot/lib/ |
Member
There was a problem hiding this comment.
On line 29 we have this rule:
# Uncomment if you have tasks that create the project's static files in wwwroot
#wwwroot/
This was added in #1590 and feels familiar to this. Could you:
- clarify what's in
wwwroot/libon your machine so we can document here what we expect (unless there are some external resources to point to) - see if we can update that rule to reflect whatever changes are coming in VS2017
Author
There was a problem hiding this comment.
The default project setup in ASP.NET Core is that the bower directory is set to wwwroot/lib. These are external resources that are restored regularly, so there should be no need to add these to VCS.
The default intended use for other directories in wwwroot is to hold user code and static resources, which should be in VCS.
Author
|
Changed reference to "ASP.NET Core" from "VS15", since it applies to prior iterations of IDE as well. |
Member
|
@marcrocny thanks! |
shiftkey
pushed a commit
that referenced
this pull request
Mar 20, 2019
ASP.NET Core projects no longer use Bower by default (since Bower is now deprecated), and instead create static files in the wwwroot/lib path. This path is can also be used by convention for ASP.NET Core developers, and since it's no longer populated by Bower, it is unituitive to be excluded by default. This change removes the lines added by #2307. **Reasons for making this change:** VS default flow is now broken by excluding files required to run an ASP.NET Core project. **Links to documentation supporting these rule changes:** The changes to the ASP.NET Core templates was tracked by aspnet/Templating#48.
Ortega-Dan
pushed a commit
to Ortega-Dan/gitignore
that referenced
this pull request
Jun 26, 2019
ASP.NET Core projects no longer use Bower by default (since Bower is now deprecated), and instead create static files in the wwwroot/lib path. This path is can also be used by convention for ASP.NET Core developers, and since it's no longer populated by Bower, it is unituitive to be excluded by default. This change removes the lines added by github#2307. **Reasons for making this change:** VS default flow is now broken by excluding files required to run an ASP.NET Core project. **Links to documentation supporting these rule changes:** The changes to the ASP.NET Core templates was tracked by aspnet/Templating#48.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In VS15 (2017) the default .bowerrc repoints the default location to wwwroot/lib, and bower package restore is ON.
Reasons for making this change:
VS default flow is bower package restore to wwwroot/lib.
Links to documentation supporting these rule changes:
None that I could find, TBH.