Remove wwwroot/lib exclusion for ASP.NET Core#3009
Merged
shiftkey merged 1 commit intogithub:masterfrom Mar 20, 2019
jimmylewis:jimmylewis-no-exclude-wwwroot-lib
Merged
Remove wwwroot/lib exclusion for ASP.NET Core#3009shiftkey merged 1 commit intogithub:masterfrom jimmylewis:jimmylewis-no-exclude-wwwroot-lib
shiftkey merged 1 commit intogithub:masterfrom
jimmylewis:jimmylewis-no-exclude-wwwroot-lib
Conversation
ASP.NET Core projects no longer use Bower by default (since Bower is now deprecated), and instead create static files in the wwwroot/lib path. This path is can also be used by convention for ASP.NET Core developers, and since it's no longer populated by Bower, it is unituitive to be excluded by default. This change removes the lines added by #2307. **Reasons for making this change:** VS default flow is now broken by excluding files required to run an ASP.NET Core project. **Links to documentation supporting these rule changes:** The changes to the ASP.NET Core templates was tracked by aspnet/Templating#48.
clboles
approved these changes
Mar 20, 2019
clboles
left a comment
There was a problem hiding this comment.
This looks good to me. We will make a corresponding change to the .gitignore that ships with Visual Studio, which is synced from this file.
filipw
approved these changes
Mar 20, 2019
Member
|
@jimmylewis thanks! |
Ortega-Dan
pushed a commit
to Ortega-Dan/gitignore
that referenced
this pull request
Jun 26, 2019
ASP.NET Core projects no longer use Bower by default (since Bower is now deprecated), and instead create static files in the wwwroot/lib path. This path is can also be used by convention for ASP.NET Core developers, and since it's no longer populated by Bower, it is unituitive to be excluded by default. This change removes the lines added by github#2307. **Reasons for making this change:** VS default flow is now broken by excluding files required to run an ASP.NET Core project. **Links to documentation supporting these rule changes:** The changes to the ASP.NET Core templates was tracked by aspnet/Templating#48.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASP.NET Core projects no longer use Bower by default (since Bower is now deprecated), and instead create static files in the wwwroot/lib path. This path is can also be used by convention for ASP.NET Core developers, and since it's no longer populated by Bower, it is unituitive to be excluded by default.
This change removes the lines added by #2307.
Reasons for making this change:
VS default flow is now broken by excluding files required to run an ASP.NET Core project.
Links to documentation supporting these rule changes:
The changes to the ASP.NET Core templates was tracked by aspnet/Templating#48.