Skip to content

Adding optional ignore proposal for wwwroot folder#1590

Merged
shiftkey merged 1 commit intogithub:masterfrom
JimiC:Optional_Ignore_wwwroot
Jul 15, 2015
Merged

Adding optional ignore proposal for wwwroot folder#1590
shiftkey merged 1 commit intogithub:masterfrom
JimiC:Optional_Ignore_wwwroot

Conversation

@JimiC
Copy link
Contributor

@JimiC JimiC commented Jul 13, 2015

There are use cases where you have gulp/grunt tasks that create the static files of a project from bower_components, images, scripts folders.

There are use cases where you have gulp/grunt tasks that create the static files of a project from bower_components, images, scripts folders.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayedihashimi is this something we should be calling out? How do you feel about the words here?

@JimiC
Copy link
Contributor Author

JimiC commented Jul 14, 2015

As additional info here is what the default ASP.NET 5 template generates in project.json.

"exclude": [
    "wwwroot",
    "node_modules",
    "bower_components"
  ],

Hovering over exclude says "Glob pattern to indicate the default files to be excluded from processing".
node_modules is included in gitignore. I know that bower_components was excluded for a reason (yeah I read the article). So this leaves us to decide the fate of wwwroot.

@sayedihashimi
Copy link
Contributor

I think there will be a good number of people excluding wwwroot so I'm OK with this.

@shiftkey
Copy link
Member

@sayedihashimi thanks! I'll take this in now.

shiftkey added a commit that referenced this pull request Jul 15, 2015
Adding optional ignore proposal for wwwroot folder
@shiftkey shiftkey merged commit 073727c into github:master Jul 15, 2015
@JimiC JimiC deleted the Optional_Ignore_wwwroot branch July 15, 2015 18:12
peterblazejewicz added a commit to peterblazejewicz/generator-aspnet that referenced this pull request Jan 6, 2016
This commit update file state to upstream project state
Thanks!
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
Adding optional ignore proposal for wwwroot folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants