test(datasets): Make test API functions more generic#366
Merged
Conversation
2180cf3 to
8e5c313
Compare
8e5c313 to
9c9b3d5
Compare
fpacifici
reviewed
Jul 18, 2019
Contributor
fpacifici
left a comment
There was a problem hiding this comment.
Seems good to me. These endpoints are all for tests.
Please merge master or rebase since your code may not merge cleanly now.
Please run the sentry tests then I can accept:
https://github.com/getsentry/snuba#testing-against-sentry
These are the test that use these endpoints.
9c9b3d5 to
fab2ad7
Compare
Contributor
Author
|
Great. The tests look happy. |
fpacifici
approved these changes
Jul 22, 2019
This commit introduces three new endpoints: - `/tests/<datastream>/insert` - `/tests/<datastream>/eventstream` - `/tests/<datastream>/drop` These are more generic version of existing endpoints (`/tests/drop`, `/tests/eventstream`, `/tests/insert`). The existing endpoints only work for the events dataset. The new endpoints will work on any dataset. Once github.com/getsentry/sentry is updated to use the new endpoints, the old endpoints will be removed.
fab2ad7 to
e900d17
Compare
manuzope
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jul 23, 2019
When we run tests in Sentry that hit Snuba, we insert records and delete the database at the end of every test run. We do this using the following test endpoints in Snuba: * `/tests/insert` * `/tests/eventstream` * `/tests/drop` These endpoints only worked for the `events` dataset. We want it to work for any dataset. So, getsentry/snuba#366 introduced 3 new test endpoints to Snuba with the goal of replacing the 3 endpoints mentioned earlier: * `/tests/<datastream>/insert` * `/tests/<datastream>/eventstream` * `/tests/<datastream>/drop` This PR makes Sentry use the new endpoints in Snuba. The next step is to remove the old non-generic endpoints from Snuba.
manuzope
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jul 23, 2019
When we run tests in Sentry that hit Snuba, we insert records and delete the database at the end of every test run. We do this using the following test endpoints in Snuba: * `/tests/insert` * `/tests/eventstream` * `/tests/drop` These endpoints only worked for the `events` dataset. We want it to work for any dataset. So, getsentry/snuba#366 introduced 3 new test endpoints to Snuba with the goal of replacing the 3 endpoints mentioned earlier: * `/tests/<datastream>/insert` * `/tests/<datastream>/eventstream` * `/tests/<datastream>/drop` This PR makes Sentry use the new endpoints in Snuba. The next step is to remove the old non-generic endpoints from Snuba.
manuzope
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jul 23, 2019
When we run tests in Sentry that hit Snuba, we insert records and delete the database at the end of every test run. We do this using the following test endpoints in Snuba: * `/tests/insert` * `/tests/eventstream` * `/tests/drop` These endpoints only worked for the `events` dataset. We want it to work for any dataset. So, getsentry/snuba#366 introduced 3 new test endpoints to Snuba with the goal of replacing the 3 endpoints mentioned earlier: * `/tests/<datastream>/insert` * `/tests/<datastream>/eventstream` * `/tests/<datastream>/drop` This PR makes Sentry use the new endpoints in Snuba. The next step is to remove the old non-generic endpoints from Snuba.
manuzope
pushed a commit
that referenced
this pull request
Jul 24, 2019
* #366 introduced more generic test endpoints * getsentry/sentry#14111 made Sentry use those generic test endpoints This PR removes the old non-generic test endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces three new endpoints:
/tests/<datastream>/insert/tests/<datastream>/eventstream/tests/<datastream>/dropThese are more generic versions of existing endpoints (
/tests/insert,/tests/eventstream,/tests/drop). The existing endpoints only work for the events dataset. The goal of the new endpoints is that they work for any dataset.Once github.com/getsentry/sentry is updated to use the new endpoints, the old endpoints will be removed.