test(datasets): Make Sentry use generic test functions in Snuba#14111
Merged
test(datasets): Make Sentry use generic test functions in Snuba#14111
Conversation
When we run tests in Sentry that hit Snuba, we insert records and delete the database at the end of every test run. We do this using the following test endpoints in Snuba: * `/tests/insert` * `/tests/eventstream` * `/tests/drop` These endpoints only worked for the `events` dataset. We want it to work for any dataset. So, getsentry/snuba#366 introduced 3 new test endpoints to Snuba with the goal of replacing the 3 endpoints mentioned earlier: * `/tests/<datastream>/insert` * `/tests/<datastream>/eventstream` * `/tests/<datastream>/drop` This PR makes Sentry use the new endpoints in Snuba. The next step is to remove the old non-generic endpoints from Snuba.
2c107e3 to
d8831aa
Compare
jan-auer
added a commit
that referenced
this pull request
Jul 24, 2019
* master: (115 commits) feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116) fix(apm): Whitelist dev.getsentry.net for local development (#14117) test(datasets): Make Sentry use generic test functions in Snuba (#14111) ref(suspect-commits): Add text changes to empty state (#14121) build: Switch to psycopg2-binary feat(api): Add option to fetch Organization details without Pr… (#13925) ref: Remove EventDetails endpoint (#14107) test(ui): Mock the onboarding learn more video (#14108) tests(acceptance): Add tests for resolving issues in Issues Li… (#14069) feat(ui): Add basic templates for Incident Rules in settings (#14112) feat(eventsv2) Add basic transaction list (#14103) ref(environments) Optimize environment queries (#14102) fix(events-v2) Add additional user attributes to the user column (#14101) fix: Don't start pageload transaction (#14115) feat: APM Sentry Frontend (#14027) ref(onboarding): Fix install promprt URL (#14106) fix(app-platform): Allow GET requests for published apps (#14109) feat: Update Group.get_latest_event to use Snuba event (#14039) ref(onboarding): Rename wizardNew -> onboarding (#14104) feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040) ...
manuzope
pushed a commit
to getsentry/snuba
that referenced
this pull request
Jul 24, 2019
* #366 introduced more generic test endpoints * getsentry/sentry#14111 made Sentry use those generic test endpoints This PR removes the old non-generic test endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When we run tests in Sentry that hit Snuba, we insert records and delete the database at the end of every test run. We do this using the following test endpoints in Snuba:
/tests/insert/tests/eventstream/tests/dropProblem
These endpoints only worked for the
eventsdataset. We want it to work for any dataset.Solution
So, getsentry/snuba#366 introduced 3 new test endpoints to Snuba with the goal of replacing the 3 endpoints mentioned earlier:
/tests/<datastream>/insert/tests/<datastream>/eventstream/tests/<datastream>/dropThis PR makes Sentry use the new endpoints in Snuba. The next step is to remove the old non-generic endpoints from Snuba.