test(datasets): Remove old test functions#370
Merged
Conversation
14b3bc1 to
dab15cd
Compare
tkaemming
approved these changes
Jul 24, 2019
Contributor
There was a problem hiding this comment.
Note that this will cause anybody running the Snuba suite locally to have failing tests until they pull the latest Docker image with sentry devservices down/sentry devservices up. (I guess that is also true to some extent for getsentry/sentry#14111 as well, since that requires new APIs.) We should either send out an email or be ready to field questions about this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the old non-generic test endpoints.