Skip to content

Conversation

@JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Oct 21, 2025

Part of #1413

#skip-changelog

@supervacuus supervacuus merged commit b4ef51e into ref/win/make_path_narrow_utf8_on_windows Oct 21, 2025
36 of 37 checks passed
@supervacuus supervacuus deleted the joshua/patch/utf8_const branch October 21, 2025 12:58
supervacuus pushed a commit that referenced this pull request Oct 23, 2025
supervacuus added a commit that referenced this pull request Oct 23, 2025
* fix: make narrow utf-8 canonical across platforms

* fix unix path effects

* sentry__filewriter_byte_count now takes a const filewriter
* sentry__path_filename always returns a char.

* provide a platform-dependent accessor for the crashpad backend

* eliminate double-free sentry__path_from_str_owned.

* use correct format specifier for cli in debug logger for spawn

* Apply suggestion from @JoshuaMoelans

Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>

* introduce `expect_failure` parameter to integration test run()

* reintroduce wide string comparisons in unit-tests

* update changelog

* clarify encoding in public header and clean up inline docs generally

* clarify encoding in the path header

* clarify remove behavior in the path header and fix windows implementation

* apply review feedback and various cleanups

* clean up

sentry__path_append_str()
sentry__path_absolute()
sentry__path_clone()

* update changelog

* format

* update breakpad

* fix "unknown command tag name"

* update breakpad

* update crashpad

* update changelog

* fix is_last_error_path_not_found() definition

* update breakpad to handler branch

* fixup changelog after master rebase

* add NULL check to sentry__string_clone_wstr

* clean up crash_marker path strin accessor

* add more `const` (#1422)

* Update include/sentry.h

Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>

* Update include/sentry.h

Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>

* limit system allocated `_wfullpath()` buffer to the `sentry__path_absolute()` scope

use `free()` internally in the function, and
clone the resulting wide-string at the end so we can be sure that the absolute path being passed around is not using system allocated buffer.

* document breaking change

* fix(logs): add `expect_failure` to logs_on_crash tests (#1421)

* add check for unexpected fail

* refactor logs tests to use expect_failure

* add missing `expect_failure` for logger tests

* fix copy mistake

* infer check `expect_failure` and remove from passed-in kwargs

* remove check from run_benchmark

* add check for `check` in kwargs

* Try to run the entire test-suite against a UTF-8 CWD

* realign with crashpad getsentry branch like master

* make the external crashreporter fixture wide-string aware on Windows.

* clean up external crashreporter fixture (fwprintf + SetConsoleOutputCP instead of explict wide to multibyte conversion)

* use wmain in the external crash reporter fixture only when building for _MSC_VER

* wait at the end of the WER integration tests that no WerFault.exe instances are still running

* clean up wide-to-multibyte string handling

---------

Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants