-
-
Notifications
You must be signed in to change notification settings - Fork 200
fix(win): make narrow utf-8 the canoncial path encoding #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(win): make narrow utf-8 the canoncial path encoding #1413
Conversation
9f454e4 to
d258fd6
Compare
d258fd6 to
2e4e448
Compare
|
@JoshuaMoelans, can you give this a first once over? This is not fully completed according to the scope I had in mind. Still, the PR reflects the most significant portion requiring restructuring, and I would appreciate some SDK internals WTF count from your POV. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good on a first viewing. A few minor comments about some cleanup & clarification.
f390f3d to
ba2c115
Compare
JoshuaMoelans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
I don't know what is going on with the cursor bot today, but the "bugs" it raises are pure gold: #1413 (comment) #1413 (comment) #1413 (comment) And so densely written, it is a pleasure to decipher. This is clearly the future of software development 🤗 |
* sentry__filewriter_byte_count now takes a const filewriter * sentry__path_filename always returns a char.
Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>
617f769 to
b71ee72
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Bug: Crash Reporter: Redundant Conditional CompilationThe Windows version of the crash reporter uses |
…P instead of explict wide to multibyte conversion)
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
PR #1413 changed the arg0 parameter from sentry_pathchar_t* to char* as part of making narrow UTF-8 the canonical path encoding, but the signature in sentry_process_none.c was not updated. This fixes the function signature to match the declaration, changing arg0 from `const sentry_pathchar_t *` to `const char *`. Fixes regression from #1413 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…1436) * fix: correct sentry__process_spawn signature in none implementation PR #1413 changed the arg0 parameter from sentry_pathchar_t* to char* as part of making narrow UTF-8 the canonical path encoding, but the signature in sentry_process_none.c was not updated. This fixes the function signature to match the declaration, changing arg0 from `const sentry_pathchar_t *` to `const char *`. Fixes regression from #1413 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Update CHANGELOG with unreleased fixes Added unreleased section with fixes for PS5/Switch compilation regression. --------- Co-authored-by: Claude <noreply@anthropic.com>
Fixes #1397 (which also contains an explanation of the approach followed in this PR).
Fixes #1410.