-
-
Notifications
You must be signed in to change notification settings - Fork 200
fix(logs): add expect_failure to logs_on_crash tests
#1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoshuaMoelans
merged 7 commits into
ref/win/make_path_narrow_utf8_on_windows
from
joshua/patch/logs_tests_expected_fail
Oct 22, 2025
Merged
fix(logs): add expect_failure to logs_on_crash tests
#1421
JoshuaMoelans
merged 7 commits into
ref/win/make_path_narrow_utf8_on_windows
from
joshua/patch/logs_tests_expected_fail
Oct 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supervacuus
approved these changes
Oct 21, 2025
2622b9a
into
ref/win/make_path_narrow_utf8_on_windows
36 checks passed
supervacuus
pushed a commit
that referenced
this pull request
Oct 23, 2025
* add check for unexpected fail * refactor logs tests to use expect_failure * add missing `expect_failure` for logger tests * fix copy mistake * infer check `expect_failure` and remove from passed-in kwargs * remove check from run_benchmark * add check for `check` in kwargs
supervacuus
added a commit
that referenced
this pull request
Oct 23, 2025
* fix: make narrow utf-8 canonical across platforms * fix unix path effects * sentry__filewriter_byte_count now takes a const filewriter * sentry__path_filename always returns a char. * provide a platform-dependent accessor for the crashpad backend * eliminate double-free sentry__path_from_str_owned. * use correct format specifier for cli in debug logger for spawn * Apply suggestion from @JoshuaMoelans Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com> * introduce `expect_failure` parameter to integration test run() * reintroduce wide string comparisons in unit-tests * update changelog * clarify encoding in public header and clean up inline docs generally * clarify encoding in the path header * clarify remove behavior in the path header and fix windows implementation * apply review feedback and various cleanups * clean up sentry__path_append_str() sentry__path_absolute() sentry__path_clone() * update changelog * format * update breakpad * fix "unknown command tag name" * update breakpad * update crashpad * update changelog * fix is_last_error_path_not_found() definition * update breakpad to handler branch * fixup changelog after master rebase * add NULL check to sentry__string_clone_wstr * clean up crash_marker path strin accessor * add more `const` (#1422) * Update include/sentry.h Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com> * Update include/sentry.h Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com> * limit system allocated `_wfullpath()` buffer to the `sentry__path_absolute()` scope use `free()` internally in the function, and clone the resulting wide-string at the end so we can be sure that the absolute path being passed around is not using system allocated buffer. * document breaking change * fix(logs): add `expect_failure` to logs_on_crash tests (#1421) * add check for unexpected fail * refactor logs tests to use expect_failure * add missing `expect_failure` for logger tests * fix copy mistake * infer check `expect_failure` and remove from passed-in kwargs * remove check from run_benchmark * add check for `check` in kwargs * Try to run the entire test-suite against a UTF-8 CWD * realign with crashpad getsentry branch like master * make the external crashreporter fixture wide-string aware on Windows. * clean up external crashreporter fixture (fwprintf + SetConsoleOutputCP instead of explict wide to multibyte conversion) * use wmain in the external crash reporter fixture only when building for _MSC_VER * wait at the end of the WER integration tests that no WerFault.exe instances are still running * clean up wide-to-multibyte string handling --------- Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1413
Also adds a check if
expect_failureis False, which helps us catch tests which are missing this value.#skip-changelog