-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Comparing changes
Open a pull request
base repository: getsentry/sentry-javascript
base: cf062ba
head repository: getsentry/sentry-javascript
compare: 9a7af57
- 20 commits
- 198 files changed
- 10 contributors
Commits on Jan 19, 2024
-
feat: Refactor exposed
defaultIntegrationsto `getDefaultIntegratio……ns()` (#10243) The current implementation has two problems: 1. It is weird that you can accidentally mutate the default integrations of another package 2. We sometimes have logic-based default integrations - e.g. adding an integration only if tracing is enabled, or similar. This means that either we have to add some logic in the _upstream_ SDK to ensure this is still added even if downstream SDKs overwrite default integrations, or we need to duplicate the logic in the _downstream_ SDKs. With this new method, we can instead centralize this, and downstream SDKs simply need to call upstream `getDefaultIntegrations(options)`.
Configuration menu - View commit details
-
Copy full SHA for 33d1cb0 - Browse repository at this point
Copy the full SHA 33d1cb0View commit details -
fix(next): Fix custom integrations (#10220)
The usage of this was not really working well to begin with, and even worse with the new functional integrations. Because if the user adds the integration themselves (e.g. `integrations: [new RewriteFrames()]`), it will not actually get the correct iteratee at all. Overall it is much cleaner anyhow to just fork the integrations properly and use them instead of the default one - then we can rely on the standard behavior of merging integrations etc. We need to do the same for basically all usages of `addOrUpdateIntegration`, as that actually does not work at all anymore with the functional integrations 😬 (and in many instances never really worked properly if users passed in a custom integration themselves). Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Configuration menu - View commit details
-
Copy full SHA for 4c0481b - Browse repository at this point
Copy the full SHA 4c0481bView commit details -
ref(astro): Streamline how we add browser tracing (#10253)
We should wait for #10243 to merge this, as otherwise we'll get a deprecation/eslint error there.
Configuration menu - View commit details
-
Copy full SHA for 7688b60 - Browse repository at this point
Copy the full SHA 7688b60View commit details -
getsentry-bot committed
Jan 19, 2024 Configuration menu - View commit details
-
Copy full SHA for fc0e55f - Browse repository at this point
Copy the full SHA fc0e55fView commit details -
Merge pull request #10265 from getsentry/master
[Gitflow] Merge master into develop
Configuration menu - View commit details
-
Copy full SHA for b916548 - Browse repository at this point
Copy the full SHA b916548View commit details -
ref: Streamline SDK metadata handling (#10251)
There have been tries to do this before, but let's see how things stand today...
Configuration menu - View commit details
-
Copy full SHA for f3b2e7d - Browse repository at this point
Copy the full SHA f3b2e7dView commit details -
feat(core): Deprecate
Span.parentSpanId(#10244)Deprecate the `Span.parentSpanId` field on the interface and class. This required only a couple of code replacements and a bunch of test adjustments. Also went ahead and changed the integration test event type in the tests I was modifying.
Configuration menu - View commit details
-
Copy full SHA for d3fecc1 - Browse repository at this point
Copy the full SHA d3fecc1View commit details -
feat(core): Deprecate
Span.originin favor ofsentry.originattri……bute (#10260) Deprecate the `Span.origin` field on the class and the interface. It will be replaced in v8 by the semantic `sentry.op` attribute.
Configuration menu - View commit details
-
Copy full SHA for 1cceeae - Browse repository at this point
Copy the full SHA 1cceeaeView commit details -
ref(wasm): Convert wasm integration to functional integration (#10230)
We should think about moving the wasm integration into `@sentry/browser` and removing `@sentry/wasm` all together. What do you think?
Configuration menu - View commit details
-
Copy full SHA for 5f0b506 - Browse repository at this point
Copy the full SHA 5f0b506View commit details
Commits on Jan 22, 2024
-
fix(wasm): Add
@sentry/coreas a dependency (#10283)By using functional integrations in #10230, we started importing from `@sentry/core` in the WASM integration. However, we didn't register `@sentry/core` as a dependency, making rollup bundle core into the package output. This changed the `build/npm` directory structure, making our entry points in `package.json` invalid. This PR fixes things by simply registering core as a dependency of wasm. If we move WASM to core (which I strongly think we should do), we'll be able to get rid of this again.
Configuration menu - View commit details
-
Copy full SHA for 7e3207d - Browse repository at this point
Copy the full SHA 7e3207dView commit details
Commits on Jan 23, 2024
-
feat: Make
parameterizefunction available through browser and node…… API (#10085) Move `parameterize` function to core, export it to upstream packages via browser and node.
Configuration menu - View commit details
-
Copy full SHA for a27deca - Browse repository at this point
Copy the full SHA a27decaView commit details -
fix(replay-canvas): Add missing dependency on @sentry/utils (#10279)
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
Configuration menu - View commit details
-
Copy full SHA for 6868256 - Browse repository at this point
Copy the full SHA 6868256View commit details -
feat(replay): Deprecate Replay, ReplayCanvas, Feedback classes (#10270)
Instead, users should use the new functional styles. Note that we'll probably actually un-deprecate `Replay` in some form in v8, as we'll be keeping the class around there for sure (as there is a lot of logic in there...). But users should not use it, so deprecating this now! While at it, I also deprecated the old `InitSentryForEmber` method in favor of `init()`. It's slightly unfortunate that I missed this, but we probably shouldn't have exposed `ReplayCanvas` as a class anymore at all 😬 maybe we wait before we document this etc. until we merged the functional style. cc @billyvg
Configuration menu - View commit details
-
Copy full SHA for a682534 - Browse repository at this point
Copy the full SHA a682534View commit details -
feat(sveltekit): Update default integration handling & deprecate `add…
…OrUpdateIntegration` (#10263) This updates the last usage of `addOrUpdateIntegration` and deprecates it.
Configuration menu - View commit details
-
Copy full SHA for 62b0c4d - Browse repository at this point
Copy the full SHA 62b0c4dView commit details -
feat(feedback): Configure feedback border radius (#10289)
Adds ability to configure all border radiuses on feedback widget Closes #10256
Configuration menu - View commit details
-
Copy full SHA for a0b987a - Browse repository at this point
Copy the full SHA a0b987aView commit details -
feat(core): Expose
isInitialized()to replace checking via `getClie……nt` (#10296) Currently, you can use `Sentry.getClient() !== undefined` to check if Sentry was initialized. In v8, we want to change this so that this _always_ returns a client (possibly a Noop client), so this check will not work anymore there. Instead, we can provide a new util that does this explicitly, where we can control what it checks under the hood.
Configuration menu - View commit details
-
Copy full SHA for 675309d - Browse repository at this point
Copy the full SHA 675309dView commit details -
fix(tracing): Don't send negative ttfb (#10286)
As per https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStart, `responseStart` can be 0 if the request is coming straight from the cache. This might lead us to calculate a negative ttfb. To account for these scenarios, use `Math.max` to make sure we always set to 0 in the case of a negative value.
Configuration menu - View commit details
-
Copy full SHA for c017181 - Browse repository at this point
Copy the full SHA c017181View commit details -
Configuration menu - View commit details
-
Copy full SHA for d98bd74 - Browse repository at this point
Copy the full SHA d98bd74View commit details -
Merge pull request #10298 from getsentry/prepare-release/7.95.0
meta(changelog): Update changelog for v7.95.0
Configuration menu - View commit details
-
Copy full SHA for 9fcfd51 - Browse repository at this point
Copy the full SHA 9fcfd51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a7af57 - Browse repository at this point
Copy the full SHA 9a7af57View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff cf062ba...9a7af57