fix(wasm): Add @sentry/core as a dependency#10283
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
commented
Jan 22, 2024
| - 'packages/replay/**' | ||
| - 'packages/replay-canvas/**' | ||
| - 'packages/feedback/**' | ||
| - 'packages/wasm/**' |
Member
Author
There was a problem hiding this comment.
just noticed that our PW integration tests didn't run for the WASM package, so I added it to the browser category for our CI job selection
lforst
approved these changes
Jan 22, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using functional integrations in #10230, we started importing from
@sentry/corein the WASM integration. However, we didn't register@sentry/coreas a dependency, making rollup bundle core into the package output. This changed thebuild/npmdirectory structure, making our entry points inpackage.jsoninvalid.This PR fixes things by simply registering core as a dependency of wasm. If we move WASM to core (which I strongly think we should do), we'll be able to get rid of this again.