feat(core): Deprecate Span.origin in favor of sentry.origin attribute#10260
Merged
feat(core): Deprecate Span.origin in favor of sentry.origin attribute#10260
Span.origin in favor of sentry.origin attribute#10260Conversation
Contributor
size-limit report 📦
|
mydea
approved these changes
Jan 19, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
this makes sense, and probably I agree we can also remove it from StartSpanOptions!
Member
Author
|
heads-up (cc @mydea since you already reviewed): Similarly to |
9e21e01 to
500c3ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
Span.originfield on the class and the interface. It will be replaced in v8 by the semanticsentry.opattribute .For now, I didn't yet deprecate
SpanContext.originbut I think we could do it quite easily by just setting the origin inattributeswhen starting spans. Happy to tackle in a follow-up PR if we want to do this.ref #10184