Skip to content

Upgrade to React 15.2.1 [try 2] (#3689)#3734

Merged
benvinegar merged 13 commits intomasterfrom
react-15-try-2
Jul 17, 2016
Merged

Upgrade to React 15.2.1 [try 2] (#3689)#3734
benvinegar merged 13 commits intomasterfrom
react-15-try-2

Conversation

@benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Jul 14, 2016 •
edited by dcramer
Loading

This change is Reviewable

@benvinegar
Copy link
Contributor Author

benvinegar commented Jul 15, 2016 •
edited
Loading

Current status is that the acceptance tests on Travis CI really do not like this branch. They pass 100% locally on OS X, but on Travis CI (Ubuntu), the acceptance tests can't seem to connect to WebDriver/PhantomJS – even on pages that don't load any JavaScript/React at all (i.e. mail debug views).

At this point I have only a single email view test running, but still getting this BadStatusLine exception:

Traceback (most recent call last):
  File "/home/travis/build/getsentry/sentry/tests/acceptance/test_auth.py", line 21, in test_no_credentials
    self.enter_auth('', '')
  File "/home/travis/build/getsentry/sentry/tests/acceptance/test_auth.py", line 11, in enter_auth
    self.browser.get('/auth/login/')
  File "/home/travis/build/getsentry/sentry/src/sentry/utils/pytest.py", line 37, in get
    self.driver.get(self.route(path), *args, **kwargs)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 248, in get
    self.execute(Command.GET, {'url': url})
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 234, in execute
    response = self.command_executor.execute(driver_command, params)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/selenium/webdriver/remote/remote_connection.py", line 401, in execute
    return self._request(command_info[0], url, body=data)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/selenium/webdriver/remote/remote_connection.py", line 471, in _request
    resp = opener.open(request, timeout=self._timeout)
  File "/opt/python/2.7.9/lib/python2.7/urllib2.py", line 431, in open
    response = self._open(req, data)
  File "/opt/python/2.7.9/lib/python2.7/urllib2.py", line 449, in _open
    '_open', req)
  File "/opt/python/2.7.9/lib/python2.7/urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "/opt/python/2.7.9/lib/python2.7/urllib2.py", line 1227, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/opt/python/2.7.9/lib/python2.7/urllib2.py", line 1200, in do_open
    r = h.getresponse(buffering=True)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/raven/breadcrumbs.py", line 328, in getresponse
    rv = real_getresponse(self, *args, **kwargs)
  File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 1073, in getresponse
    response.begin()
  File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 415, in begin
    version, status, reason = self._read_status()
  File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 379, in _read_status
    raise BadStatusLine(line)
BadStatusLine: ''

@benvinegar
Copy link
Contributor Author

benvinegar commented Jul 15, 2016

@fotinakis – @dcramer suggested I reach out. Ever seen this (^) before?

@fotinakis
Copy link
Contributor

fotinakis commented Jul 15, 2016

@benvinegar unfortunately I haven't seen that, my experience with Selenium is usually through a Ruby wrapper library and I have very little knowledge of the python webdrivers. This looks like what is happening: http://stackoverflow.com/a/27530824/128597

@benvinegar
Copy link
Contributor Author

benvinegar commented Jul 17, 2016

This looks like what is happening: http://stackoverflow.com/a/27530824/128597

Yep, found that link, but the issue here is that Selenium isn't even starting once. Seems like it might be Travis related, because it magically cleaned up by itself.

@benvinegar benvinegar merged commit 7fdcc5f into master Jul 17, 2016
@benvinegar benvinegar deleted the react-15-try-2 branch July 17, 2016 20:30
benvinegar added a commit that referenced this pull request Jul 17, 2016
@benvinegar
Revert "Upgrade to React 15.2.1 [try 2] (#3689) (#3734)"
80990d8 
This reverts commit 7fdcc5f.
benvinegar added a commit that referenced this pull request Jul 18, 2016
@benvinegar
Revert "Upgrade to React 15.2.1 [try 2] (#3689) (#3734)" (#3743)
798b5a7 
This reverts commit 7fdcc5f.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benvinegar @fotinakis