Revert "Upgrade to React 15.2.1 [try 2] (#3689) (#3734)"#3743
Revert "Upgrade to React 15.2.1 [try 2] (#3689) (#3734)"#3743benvinegar merged 1 commit intomasterfrom
Conversation
|
This thread is the closest thing I've found on the web that seems to match this error – and Travis also runs Ubuntu. |
|
Also the acceptance tests still pass if you re-run the original (now merged) branch: https://travis-ci.org/getsentry/sentry/jobs/144891187 |
|
Okay, I think I have something. If I start deleting caches and re-running tests, they start to fail. I think that we have begun to download a new version of Selenium for which this bug is present (2.53.6 was introduced 2 weeks ago), and that I just conveniently was the first person to hit it when I introduced my React branch (with a new cache). I'm going to experiment with pinning |
|
Nice @benvinegar! Yes, pinning Selenium versions is I think pretty common because the webdriver interface unfortunately sometimes breaks compatibility with browsers between versions of either. If you find a pattern that works and seems to fix the |
|
@fotinakis – So, that didn't work. I tried pinning the last 2 previous versions and nothing helped. This is becoming a serious issue. If I have to choose between never upgrading my client side libs and running acceptance tests, I'm going to ditch the acceptance tests. Would really appreciate some help on this because I'm completely in the dark. |
|
new pr open on #3747 |
This reverts commit 7fdcc5f.
Build is broken again so I'm reverting again.
I basically don't know what to do anymore. Before I merged, the acceptance test was green. I even used the visual diffs created by Percy to fix some bugs. But after merging, it went red with the same
BadStatusLineSelenium/Webdriver error.cc @getsentry/team @fotinakis
This change is