Conversation
|
Looks good but we need to figure out why the stream is broken :) Review status: 0 of 7 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
| expect(searchBar.state.searchItems[0].desc).to.eql('unresolved'); | ||
| expect(searchBar.state.searchItems[0].value).to.eql('unresolved'); | ||
| expect(searchBar.state.searchTerm).to.eql('fu'); | ||
| expect(searchBar.state.searchItems.length).to.eql(0); |
There was a problem hiding this comment.
The original assertions on this test were ... completely wrong, and I'm not sure what I was doing when I wrote them. The new assertions matches the behavior from the live app today. The reason they've changed is that there was a race condition here (setState hadn't propagated yet) that seems resolved in 15.2
|
Okay, this is ready now. |
|
Reviewed 6 of 7 files at r2, 6 of 7 files at r3, 2 of 2 files at r4. Comments from Reviewable |
This reverts commit d72da69.
Blockers:
Stream doesn't render (React internal error)New warnings, deprecation notices result in noisy console(good enough)/cc @getsentry/team
This change is