ref: Refactor user reports to not use Postgres Event#13904
Conversation
Previously we queried Events in order to fetch the PG event ID, this is no longer needed.
| 'event': { | ||
| 'id': six.text_type(attrs['event']['id']) if attrs['event']['id'] else None, | ||
| 'eventID': obj.event_id | ||
| } |
There was a problem hiding this comment.
Does this change the API response in a way that could impact clients?
There was a problem hiding this comment.
Yeah, I can update to keep this in here. Since it was added later and the same information is in the eventID field, I thought it unlikely that people would be depending on it
There was a problem hiding this comment.
I think it will impact this endpoint
https://docs.sentry.io/api/projects/get-project-user-reports/
fpacifici
left a comment
There was a problem hiding this comment.
Do we have any production log to see whether anyone is using that field?
And do we actually publish anything in the docs for api breaking changes?
| 'event': { | ||
| 'id': six.text_type(attrs['event']['id']) if attrs['event']['id'] else None, | ||
| 'eventID': obj.event_id | ||
| } |
There was a problem hiding this comment.
I think it will impact this endpoint
https://docs.sentry.io/api/projects/get-project-user-reports/
* master: chore: Fix typo errywhere -> everywhere (#13934) ref: (Django 1.9) Bump djangorestframework to 3.0.5 as an intermediate step to get to 3.3.x feat(issueless events): Test eventstream work without groups (#13888) ref: Improve repr of User (#13896) feat(loader): Make the default for new js projects v5 of js sdk (#13327) build: Remove browser-reload flag (#13918) ref(ui): Consolidate server frontend hydration logic (#13868) ref: Refactor user reports to not use Postgres Event (#13904) Test/integration acceptance tests (#13895) feat: Remove ts-jest (#13846) obs(sentry_apps): Add a small metrics increment on processing resource changes. (#13897) enable testing for all orgs (#13903) ref: Update Python SDK to 0.10.0 (#13911) fix: Do not suggest Sentry.Extensions.Logging when ASP.NET Core is used (#13891) Update license year to 2019 ci(travis): Move docker-sentry builds to Dockes Hub autobuild (#13901) ref(app-platform): Add integration features to SentryAppDetailsModal (#13393) chore(ui) Rename OrganizationStream to IssueList (#13892)
Previously we queried Events in order to fetch the PG event ID, this is
no longer needed.