feat(issueless events): Make eventstream work without groups#13888
Merged
feat(issueless events): Make eventstream work without groups#13888
Conversation
untitaker
approved these changes
Jul 3, 2019
mitsuhiko
approved these changes
Jul 3, 2019
markstory
reviewed
Jul 3, 2019
| self.kafka_eventstream = KafkaEventStream() | ||
| self.kafka_eventstream.producer = Mock() | ||
|
|
||
| def __build_event(self, timestamp): |
Member
There was a problem hiding this comment.
What determines whether or not a method uses one or two _?
Contributor
There was a problem hiding this comment.
__ gets name mangling applied, _ doesn't. We have no consistent policy on that but __ definitely means: do not override in subclasses.
Member
There was a problem hiding this comment.
Totally forgot that python did that. 😊
0286c4e to
0732902
Compare
0d87133 to
bd67d21
Compare
tkaemming
reviewed
Jul 3, 2019
bd67d21 to
a6b488a
Compare
Contributor
Author
|
Removed the explicit 0 in the eventstream, and rebased |
jan-auer
added a commit
that referenced
this pull request
Jul 9, 2019
* master: chore: Fix typo errywhere -> everywhere (#13934) ref: (Django 1.9) Bump djangorestframework to 3.0.5 as an intermediate step to get to 3.3.x feat(issueless events): Test eventstream work without groups (#13888) ref: Improve repr of User (#13896) feat(loader): Make the default for new js projects v5 of js sdk (#13327) build: Remove browser-reload flag (#13918) ref(ui): Consolidate server frontend hydration logic (#13868) ref: Refactor user reports to not use Postgres Event (#13904) Test/integration acceptance tests (#13895) feat: Remove ts-jest (#13846) obs(sentry_apps): Add a small metrics increment on processing resource changes. (#13897) enable testing for all orgs (#13903) ref: Update Python SDK to 0.10.0 (#13911) fix: Do not suggest Sentry.Extensions.Logging when ASP.NET Core is used (#13891) Update license year to 2019 ci(travis): Move docker-sentry builds to Dockes Hub autobuild (#13901) ref(app-platform): Add integration features to SentryAppDetailsModal (#13393) chore(ui) Rename OrganizationStream to IssueList (#13892)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents eventstream to fail if event.group is none and convert the group_id from None to 0 before storing in clickhouse since group_id is non Nullable in clickhouse and we do not want to make it nullable.