Merged
Conversation
markstory
reviewed
Jul 4, 2019
|
|
||
| self.browser.element('input[name="name"]').send_keys('Tesla') | ||
| self.browser.element('input[name="author"]').send_keys('Elon Musk') | ||
| self.browser.element('input[name="webhookUrl"]').send_keys('https://tesla.com/webhook') |
Member
There was a problem hiding this comment.
You should use example.com just incase network requests get made down the road.
Contributor
Author
There was a problem hiding this comment.
@markstory Good suggestion. Made the change.
MeredithAnya
reviewed
Jul 5, 2019
|
|
||
| class OrganizationSentryAppAcceptanceTestCase(AcceptanceTestCase): | ||
| """ | ||
| As a user(type?), I can setup, configure, and remove a sentry app. |
Member
There was a problem hiding this comment.
This test seems like it's for the installing and uninstalling, and not setup/configure/removing a sentry app
| from sentry.testutils import AcceptanceTestCase | ||
|
|
||
|
|
||
| class OrganizationIntegrationAcceptanceTest(AcceptanceTestCase): |
Member
There was a problem hiding this comment.
Could we rename this OrganizationDeveloperSettingsAcceptanceTest (or something similar), so that it's clearer what this test is for ?
added 6 commits
July 5, 2019 11:46
…ation-acceptance-tests
…ation-acceptance-tests
jan-auer
added a commit
that referenced
this pull request
Jul 9, 2019
* master: chore: Fix typo errywhere -> everywhere (#13934) ref: (Django 1.9) Bump djangorestframework to 3.0.5 as an intermediate step to get to 3.3.x feat(issueless events): Test eventstream work without groups (#13888) ref: Improve repr of User (#13896) feat(loader): Make the default for new js projects v5 of js sdk (#13327) build: Remove browser-reload flag (#13918) ref(ui): Consolidate server frontend hydration logic (#13868) ref: Refactor user reports to not use Postgres Event (#13904) Test/integration acceptance tests (#13895) feat: Remove ts-jest (#13846) obs(sentry_apps): Add a small metrics increment on processing resource changes. (#13897) enable testing for all orgs (#13903) ref: Update Python SDK to 0.10.0 (#13911) fix: Do not suggest Sentry.Extensions.Logging when ASP.NET Core is used (#13891) Update license year to 2019 ci(travis): Move docker-sentry builds to Dockes Hub autobuild (#13901) ref(app-platform): Add integration features to SentryAppDetailsModal (#13393) chore(ui) Rename OrganizationStream to IssueList (#13892)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following acceptance tests:
Also removes some unneeded code from
test_organization_integration.py