Skip to content

[fr-FR] fix tooltip for singleTile option#9041

Merged
allyoucanmap merged 1 commit intogeosolutions-it:masterfrom
landryb:fix/i18n-singletile-fr
Mar 23, 2023
Merged

[fr-FR] fix tooltip for singleTile option#9041
allyoucanmap merged 1 commit intogeosolutions-it:masterfrom
landryb:fix/i18n-singletile-fr

Conversation

@landryb
Copy link
Copy Markdown
Contributor

@landryb landryb commented Mar 21, 2023

Description

fix a translation, per #9022 (review)

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

#8905

@offtherailz
Copy link
Copy Markdown
Member

Thank you @landryb

@landryb
Copy link
Copy Markdown
Contributor Author

landryb commented Mar 23, 2023

@tdipisa since #9022 will be backported, can we get this one backported too for consistency ? thanks !

@allyoucanmap allyoucanmap added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C276-CRAIG-2023-DEV labels Mar 23, 2023
@allyoucanmap allyoucanmap added this to the 2023.01.01 milestone Mar 23, 2023
@allyoucanmap allyoucanmap linked an issue Mar 23, 2023 that may be closed by this pull request
@allyoucanmap allyoucanmap merged commit 9aaa4a2 into geosolutions-it:master Mar 23, 2023
@allyoucanmap
Copy link
Copy Markdown
Contributor

@ElenaGallo please test this fix on dev and let us know if we can backport on 2023.01.xx, thanks

@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Mar 24, 2023

Hi @allyoucanmap @landryb I saw that the translation of Single Tile label is visible in the settings tab in the TOC and not in the advanced options of the WMS catalog.
translation

@landryb
Copy link
Copy Markdown
Contributor Author

landryb commented Mar 24, 2023

Hi @landryb I saw that the translation is visible in the settings tab in the TOC and not in the advanced options of the WMS catalog. translation

Interesting, good catch. My PR only touched/fixed the tooltip translation, didnt think about the label.

From my understanding, the translation in the TOC comes from https://github.com/geosolutions-it/MapStore2/blob/master/web/client/translations/data.fr-FR.json#L76 while the translation for the singleTile entry in the catalog advanced properties comes from https://github.com/geosolutions-it/MapStore2/blob/master/web/client/translations/data.fr-FR.json#L1506 - and the same issue is present on all translations since 2165c12 (eg https://github.com/geosolutions-it/MapStore2/blob/master/web/client/translations/data.es-ES.json#L1504 for example)

i can of course do another PR to copy the "label" values from the singleTile first translation, but maybe it'd be better to have a single translation key for both ?

@allyoucanmap ?

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Mar 24, 2023

Thank you @ElenaGallo. Don't worry @landryb, @allyoucanmap will take care of this with a new small PR to fix also a few more things involving translations.

@ElenaGallo
Copy link
Copy Markdown
Contributor

@landryb please backport to 2023.01.xx, thanks

@allyoucanmap
Copy link
Copy Markdown
Contributor

backport included in #906

@allyoucanmap allyoucanmap removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 29, 2023
tdipisa pushed a commit that referenced this pull request Mar 29, 2023
…atalog entry (#9022) (#9061)

* #8905 Allow to set singletile option on a wms catalog entry (#9022)

* #8905 [fr-FR] fix tooltip for singleTile option (#9041)

---------

Co-authored-by: Landry Breuil <landryb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to set singletile option on a wms catalog entry

5 participants