Skip to content

#8905 Allow to set singletile option on a wms catalog entry#9022

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
allyoucanmap:issue_8905
Mar 20, 2023
Merged

#8905 Allow to set singletile option on a wms catalog entry#9022
offtherailz merged 1 commit intogeosolutions-it:masterfrom
allyoucanmap:issue_8905

Conversation

@allyoucanmap
Copy link
Copy Markdown
Contributor

@allyoucanmap allyoucanmap commented Mar 15, 2023

Description

This PR introduces the single tile options for wms catalogs.
This new option is visible under the advanced settings of the catalog editor.

image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#8905

What is the new behavior?

The wms catalog advanced settings allows to select the single tile options to apply it to all the added layers

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap added this to the 2023.01.01 milestone Mar 15, 2023
@allyoucanmap allyoucanmap self-assigned this Mar 15, 2023
@allyoucanmap allyoucanmap linked an issue Mar 15, 2023 that may be closed by this pull request
Allow to set singletile option on a wms catalog entry #8905
Closed
@allyoucanmap allyoucanmap mentioned this pull request Mar 16, 2023
Closed
1 task
landryb
landryb reviewed Mar 16, 2023
View reviewed changes
web/client/translations/data.fr-FR.json
},
"singleTile": {
"label": "Single Tile",
"tooltip": "La couche est rendue sous la forme d'une seule image de tuile lorsqu'elle est ajoutée à la carte avec cette option activée"
Copy link
Copy Markdown
Contributor

@landryb landryb Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sous la forme d'une seule image lorsqu'elle will be clearer i think.

Copy link
Copy Markdown
Contributor Author

@allyoucanmap allyoucanmap Mar 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@landryb like this?

Suggested change
"tooltip": "La couche est rendue sous la forme d'une seule image de tuile lorsqu'elle est ajoutée à la carte avec cette option activée"
"tooltip": "La couche est rendue sous la forme d'une seule image lorsqu'elle est ajoutée à la carte avec cette option activée"

Copy link
Copy Markdown
Contributor

@landryb landryb Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i think so. @MaelREBOUX do you think that's meaningful enough ?

or rather Lorsque cette option est activée, la couche ajoutée à la carte est rendue sous la forme d'une seule image ?

@tdipisa tdipisa requested a review from offtherailz March 16, 2023 11:50
@landryb
Copy link
Copy Markdown
Contributor

landryb commented Mar 16, 2023

in my limited testing, it seems to work fine for WMS catalogtype (not for CSW, i agree it is out of scope), but afaict doesnt allow to globally set "singleTile": true in the config for the service from localConfig.json, eg i have this:

--- a/web/client/configs/localConfig.json
+++ b/web/client/configs/localConfig.json
@@ -86,12 +86,14 @@
               "gs_stable_csw": {
                 "url": "https://gs-stable.geo-solutions.it/geoserver/csw",
                 "type": "csw",
+                "singleTile": true,
                 "title": "GeoSolutions GeoServer CSW",
                 "autoload": true
               },
               "gs_stable_wms": {
                 "url": "https://gs-stable.geo-solutions.it/geoserver/wms",
                 "type": "wms",
+                "singleTile": true,
                 "title": "GeoSolutions GeoServer WMS",
                 "autoload": false
               },

and singleTile isnt ticked by default for the WMS server. It works fine once manually ticked.

@allyoucanmap
Copy link
Copy Markdown
Contributor Author

allyoucanmap commented Mar 16, 2023

@landryb

I think you need to add it under the layerOptions:

{
    ...,
    "gs_stable_wms": {
        "url": "https://gs-stable.geo-solutions.it/geoserver/wms",
        "type": "wms",
        "title": "GeoSolutions GeoServer WMS",
        "autoload": false,
        "layerOptions": {
            "singleTile": true
        }
    }
}

@landryb
Copy link
Copy Markdown
Contributor

landryb commented Mar 16, 2023

@landryb

I think you need to add it under the layerOptions:

{
    ...,
    "gs_stable_wms": {
        "url": "https://gs-stable.geo-solutions.it/geoserver/wms",
        "type": "wms",
        "title": "GeoSolutions GeoServer WMS",
        "autoload": false,
        "layerOptions": {
            "singleTile": true
        }
    }
}

oh you're right - that works perfectly, layers added from that catalog entry load in a single wms request, great. And now i think i understand better how i should mimic this in #8167 instead of adding a server-level property like i'm doing right now in my wip.

@offtherailz offtherailz merged commit 2165c12 into geosolutions-it:master Mar 20, 2023
@offtherailz
Copy link
Copy Markdown
Member

offtherailz commented Mar 20, 2023 •
edited
Loading

I merged this PR, missing the comment about translation.
@landryb maybe we can have an additional PR with translation fixes if needed.

@landryb landryb mentioned this pull request Mar 21, 2023
Merged
1 task
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 21, 2023
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Mar 21, 2023

@ElenaGallo can you please test in DEV and let us know if we can backport to 2023.01.xx

@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Mar 21, 2023

Test passed on DEV, @allyoucanmap please backport to 2023.01.xx, thanks

allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this pull request Mar 29, 2023
@allyoucanmap
geosolutions-it#8905 Allow to set singletile option on a wms catalog …
5f3c429 
…entry (geosolutions-it#9022)
@allyoucanmap allyoucanmap removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 29, 2023
tdipisa pushed a commit that referenced this pull request Mar 29, 2023
@allyoucanmap @landryb
[Backport 2023.01.xx] #8905 Allow to set singletile option on a wms c…
4fcdf54 
…atalog entry (#9022) (#9061)

* #8905 Allow to set singletile option on a wms catalog entry (#9022)

* #8905 [fr-FR] fix tooltip for singleTile option (#9041)

---------

Co-authored-by: Landry Breuil <landryb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offtherailz offtherailz offtherailz approved these changes

+1 more reviewer

@landryb landryb landryb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@allyoucanmap allyoucanmap

Labels

C276-CRAIG-2023-DEV enhancement

Projects

None yet

Milestone

2023.01.01

Development

Successfully merging this pull request may close these issues.

Allow to set singletile option on a wms catalog entry

5 participants

@allyoucanmap @landryb @offtherailz @tdipisa @ElenaGallo