Change UI of the import vector files functionality. Remove the widget…#4718
Merged
tdipisa merged 1 commit intogeosolutions-it:masterfrom Jan 16, 2020
UMarkau:4678-import-vector-files-problem
Merged
Change UI of the import vector files functionality. Remove the widget…#4718tdipisa merged 1 commit intogeosolutions-it:masterfrom UMarkau:4678-import-vector-files-problem
tdipisa merged 1 commit intogeosolutions-it:masterfrom
UMarkau:4678-import-vector-files-problem
Conversation
…s button from the TOC toolbar for imported files. Add translations for needed phrases. Modify tests to fit new functionality.
mbarto
reviewed
Jan 15, 2020
| </OverlayTrigger> | ||
| : null} | ||
| {this.props.activateTool.activateWidgetTool && (status === 'LAYER') && this.props.selectedLayers.length === 1 && !this.props.settings.expanded && !this.props.layerMetadata.expanded && !this.props.wfsdownload.expanded ? | ||
| {this.props.activateTool.activateWidgetTool && (status === 'LAYER') && !this.props.selectedLayers.length && !this.props.settings.expanded && !this.props.layerMetadata.expanded && !this.props.wfsdownload.expanded ? |
Contributor
There was a problem hiding this comment.
Can you explain me this change, please?
Contributor
Author
There was a problem hiding this comment.
This change is related to the second paragraph of the connected task:
Our goal is to check if the length of the selectedLayers array is more than zero then we don't want to show the widgets button and we want to show the widgets button for other cases when the length of the array is zero.
Another possible solution is to remove the code responsible for displaying the widgets buttob at all (in web/client/components/TOC/Toolbar.jsx):
but I'm not sure if this does not break the logic of other parts of the application.
mbarto
approved these changes
Jan 16, 2020
tdipisa
pushed a commit
that referenced
this pull request
Jan 24, 2020
…4783, #4718) (#4797) * Change UI of the import vector files functionality. Remove the widgets button from the TOC toolbar for imported files. Add translations for needed phrases. Modify tests to fit new functionality. * Fix style for the wizard buttons. * Modify logic of the mapimport reducer for the SET_LAYER case to remove useless success alert. * Add test to cover new behavior.
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jul 15, 2025
… rules support - add jsdocs for RulesManager page for multi-instances support for stand-alone geofence
mahmoudadel54
added a commit
that referenced
this pull request
Jul 17, 2025
…r support for stand-alone geofence (#11321) * #4718: MapStore development for multi-cluster GeoFence rules support - add jsdocs for RulesManager page for multi-instances support for stand-alone geofence * - update jsdocs for RulesManager - add new section in mapstore migration guide * Apply suggestion from @offtherailz * Apply suggestion from @offtherailz * Apply suggestion from @offtherailz --------- Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s button from the TOC toolbar for imported files.
Add translations for needed phrases. Modify tests to fit new functionality.
Description
Change UI of the import vector files functionality. Remove the widgets button from the TOC toolbar for imported files.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#4678
What is the new behavior?
UI of the import vector files functionality has been changed. Removed the widgets button from the TOC toolbar for imported files.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information