Modify logic of the mapimport reducer for the SET_LAYER case to remov…#4783
Merged
tdipisa merged 2 commits intogeosolutions-it:masterfrom Jan 23, 2020
UMarkau:4678-fix-success-alert
Merged
Modify logic of the mapimport reducer for the SET_LAYER case to remov…#4783tdipisa merged 2 commits intogeosolutions-it:masterfrom UMarkau:4678-fix-success-alert
tdipisa merged 2 commits intogeosolutions-it:masterfrom
UMarkau:4678-fix-success-alert
Conversation
…e useless success alert.
MV88
requested changes
Jan 23, 2020
Contributor
MV88
left a comment
There was a problem hiding this comment.
Hi, can you add a test for this?
Contributor
Author
Hi. Sure, I will do. |
MV88
approved these changes
Jan 23, 2020
tdipisa
pushed a commit
that referenced
this pull request
Jan 24, 2020
…4783, #4718) (#4797) * Change UI of the import vector files functionality. Remove the widgets button from the TOC toolbar for imported files. Add translations for needed phrases. Modify tests to fit new functionality. * Fix style for the wizard buttons. * Modify logic of the mapimport reducer for the SET_LAYER case to remove useless success alert. * Add test to cover new behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e useless success alert.
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#4678
What is the new behavior?
If you try to import the layers for the second time, the first validation message does not remain on the modal window.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information