#10935: update RulesManager JSDoc to document multi-instance GeoServer support for stand-alone geofence#11321
Merged
mahmoudadel54 merged 6 commits intogeosolutions-it:masterfrom Jul 17, 2025
Conversation
… rules support - add jsdocs for RulesManager page for multi-instances support for stand-alone geofence
6 tasks
offtherailz
requested changes
Jul 15, 2025
Member
offtherailz
left a comment
There was a problem hiding this comment.
I'd prefer a simplified version of the documentation, that let the application load and setup the geoserver instances by default.
IF the legacy mode is needed only for previous versions of geofence, we can simply indicate what version require a different configuration, and avoid any additional justification or unuseful explaination.
The easier way is :
- we have geofence, we configure the url, we startup mapstore and configure everything from UI.
- If a standalone version of GeoFence do not allow this, indicate the version and the settings to use
In my inline suggestion, you have to insert the GeoFence version when the legacy configuration must be used.
Comment on lines
+79
to
+89
| * *GeoFence Stand-Alone (Single Instance - Legacy)* | ||
| * | ||
| * ```json | ||
| * "geoFencePath": "geofence/rest", | ||
| * "geoFenceUrl": "https://my-domain.org/", | ||
| * "geoFenceServiceType": "geofence", | ||
| * "geoFenceGeoServerInstance": { | ||
| * "url": "https://my-domain.org/geoserver/", | ||
| * "id": 1 | ||
| * } | ||
| * ``` |
Member
There was a problem hiding this comment.
Suggested change
| * *GeoFence Stand-Alone (Single Instance - Legacy)* | |
| * | |
| * ```json | |
| * "geoFencePath": "geofence/rest", | |
| * "geoFenceUrl": "https://my-domain.org/", | |
| * "geoFenceServiceType": "geofence", | |
| * "geoFenceGeoServerInstance": { | |
| * "url": "https://my-domain.org/geoserver/", | |
| * "id": 1 | |
| * } | |
| * ``` |
- add new section in mapstore migration guide
offtherailz
reviewed
Jul 17, 2025
offtherailz
reviewed
Jul 17, 2025
offtherailz
reviewed
Jul 17, 2025
offtherailz
approved these changes
Jul 17, 2025
Contributor
Author
|
@ElenaGallo, could you please test this on DEV ? Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10935
What is the new behavior?
Update RulesManager JSDoc to document multi-instance GeoServer support is done.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information