Conversation
adapting Typescript to new types from OL
Update libs
and parse wmsLayers property too for WMS layers, fallback to what we had previously set if none is set. Some wmsLayers are array of strings, some are a single string and some aren't set.
removing any hard-coded logic that can be replaced with this config based approach. BG layer in the URL/store will stay set to their 2D equivalent, Cesium component will do the look up for the 3D counterpart without changing the store (same thing for any other imagery layer)
…ction PB-542 : take into account "config3d" layers config property
Instead of mapping locale to our i18n, which seems to break lang change after app startup, revert this part and improve the way we detect the default locale from the navigator available locales. This should alleviate the issue with only 'xx-CH' locales present in the browser's setting, while still enabling the lang change after startup
PB-621 : fix issue where lang can't be changed anymore
Layer that are telling, with a label at bottom, when was their last update weren't displayed in a manner that permit this label to be shown (it was out of scope of the map viewport with how the request was built) This fixes two things : - Limits the request to our own WMS to LV95 extent - Tells OpenLayers to not request extra information around (gutter) but keep a ratio of 1:1 when requesting a WMS (this way the update label can be inside the viewport)
…abel PB-589 : limit WMS request to LV95 extent
Those layers were called using `current` as their timestamp were added to their config. For the layer `ch.swisstopo.swissimage-product_1946` this was an issue as it only supported `1946` as timestamp and not `current`.
Passing run #2516 ↗︎Details:
Review all test suite changes for PR #908 ↗︎ |
|||||||||||||||
pakb
approved these changes
Jun 12, 2024
PB-622: Fix timed layer with only one timestamps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link