PB-621 : fix issue where lang can't be changed anymore#907
Merged
Conversation
Passing run #2507 ↗︎
Details:
Review all test suite changes for PR #907 ↗︎ |
|||||||||||||||
Instead of mapping locale to our i18n, which seems to break lang change after app startup, revert this part and improve the way we detect the default locale from the navigator available locales. This should alleviate the issue with only 'xx-CH' locales present in the browser's setting, while still enabling the lang change after startup
7bd9c8c to
778eefb
Compare
ltshb
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of mapping locale to our i18n, which seems to break lang change after app startup, revert this part and improve the way we detect the default locale from the navigator available locales. This should alleviate the issue with only 'xx-CH' locales present in the browser's setting, while still enabling the lang change after startup
Test link