PB-542 : take into account "config3d" layers config property#904
Merged
PB-542 : take into account "config3d" layers config property#904
Conversation
and parse wmsLayers property too for WMS layers, fallback to what we had previously set if none is set. Some wmsLayers are array of strings, some are a single string and some aren't set.
Passing run #2502 ↗︎
Details:
Review all test suite changes for PR #904 ↗︎ |
|||||||||||||||
removing any hard-coded logic that can be replaced with this config based approach. BG layer in the URL/store will stay set to their 2D equivalent, Cesium component will do the look up for the 3D counterpart without changing the store (same thing for any other imagery layer)
041db1e to
0942e84
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and improve how we parse WMS layer config, taking into account possible "wmsLayers" property
This means that the BG layer set in the URL stays the same while going 3D, and CesiumMap component looks up for 3D equivalent for any WMS/WMTS (background included) if they are defined.
This should fix the issue we had with
ch.bazl.luftfahrthindernisin 3D, where the "Last updated" label was on each tile (3D can't load a single tile WMS, so there's a specific 3D config for this one, among others)Test link