Skip to content

PB-589 : limit WMS request to LV95 extent#886

Merged
pakb merged 1 commit intodevelopfrom
bug_PB-589_no_last_update_wms_label
Jun 12, 2024
Merged

PB-589 : limit WMS request to LV95 extent#886
pakb merged 1 commit intodevelopfrom
bug_PB-589_no_last_update_wms_label

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Jun 10, 2024

Layer that are telling, with a label at bottom, when was their last update weren't displayed in a manner that permit this label to be shown (it was out of scope of the map viewport with how the request was built)

This fixes two things :

  • Limits the request to our own WMS to LV95 extent
  • Tells OpenLayers to not request extra information around (gutter) but keep a ratio of 1:1 when requesting a WMS (this way the update label can be inside the viewport)

Good candidate to test : ch.bazl.luftfahrthindernis
Test link with layer
Test link

@pakb pakb requested review from ltkum and ltshb June 10, 2024 08:04
@github-actions github-actions bot added the bug label Jun 10, 2024
@cypress
Copy link

cypress bot commented Jun 10, 2024

Passing run #2509 ↗︎

0 208 20 0 Flakiness 0

Details:

PB-589 : limit WMS request to LV95 extent
Project: web-mapviewer Commit: 885fdd70a7
Status: Passed Duration: 05:28 💡
Started: Jun 12, 2024 1:53 PM Ended: Jun 12, 2024 1:59 PM

Review all test suite changes for PR #886 ↗︎

Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the viewer when zooming, the box is a bit under the slightly transparent footer
image
If there is an easy way to move the box a few pixels up, that would be great, but I can live with the box being where it is

In 3d, those labels appear in the middle of every tile.
image
We can fix this issue in a second PR (as the cause is most certainly not the same),but this would be better if the behavior between 2d and 3d was the same

@pakb
Copy link
Contributor Author

pakb commented Jun 10, 2024

In 3d, those labels appear in the middle of every tile.

OK, that opened up another huge can of worms 🙈
I found out that some layers have a config3d property in the JSON layer config, and we are to swap to the config3d layer ID...

That will requires a bigger change and I will do that separately

EDIT : I created a ticket for this 3D issue, and I bet it will be done post go-live 🤷
https://jira.swisstopo.ch/browse/PB-619

Fixed by #904

@pakb pakb force-pushed the bug_PB-589_no_last_update_wms_label branch 2 times, most recently from 1474d72 to f84bee8 Compare June 11, 2024 14:39
@pakb pakb requested review from ltkum and ltshb June 11, 2024 15:05
@pakb pakb force-pushed the bug_PB-589_no_last_update_wms_label branch from f84bee8 to d5daa51 Compare June 12, 2024 07:17
@pakb pakb force-pushed the bug_PB-589_no_last_update_wms_label branch from d5daa51 to 18ff2cd Compare June 12, 2024 09:31
Layer that are telling, with a label at bottom, when was their last update weren't displayed in a manner that permit this label to be shown (it was out of scope of the map viewport with how the request was built)

This fixes two things :
 - Limits the request to our own WMS to LV95 extent
 - Tells OpenLayers to not request extra information around (gutter) but keep a ratio of 1:1 when requesting a WMS (this way the update label can be inside the viewport)
@pakb pakb force-pushed the bug_PB-589_no_last_update_wms_label branch from 18ff2cd to 885fdd7 Compare June 12, 2024 13:50
@pakb pakb merged commit 3ef86ed into develop Jun 12, 2024
@pakb pakb deleted the bug_PB-589_no_last_update_wms_label branch June 12, 2024 14:09
@cypress cypress bot mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants