Conversation
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…redirects-1.15.6 Bump follow-redirects from 1.15.5 to 1.15.6
… file In import file when entering enter with an invalid url field, it triggered a page reload. This was due to the fact that the `loadFile()` was triggered with an invalid url which triggered a fetch to the current host, reloading the app. Now we prevent calling loadFile() if the url is not valid.
An HTML form default behavior en keydow.enter is to submit the form which may trigger a page reload. Therefore remove the form as we don't really need it here and use `prevent` modifier for extra future security.
PB-294: Avoid reloading the application when entering ENTER in import file
The print area preview composable was doing the preview, the printing and also coffee. It is now only responsible for the preview area. I also took the opportunity to remove from the store things that weren't making much sense being there, as no one else as the print menu section was using them (and as the menu section is now the one triggering the print job, it's much clearer this way)
Move "print" job logic and management out of area composable
The new @features param wasn't checking that it was looping over features with layer, creating error when selecting drawing features The geometry of a feature came sometimes directly from the store, and was shallow-cloned only by reproject utils. Vuex was then raising an error because reproject attempted to modify something coming from the store. We now deep-clone the geometry before passing it to reproject
…o_layer Fix two bugs regarding selected features
…ton-without-legend PB-324: Show layer info button without legend
Also remove the border of button which don't need a user feedback on click, like for example the caret, checkbox and cog icon, as they are animated then don't require any feedback.
Use caret instead of plus/minus icons
Passing run #1369 ↗︎Details:
Review all test suite changes for PR #744 ↗︎ |
|||||||||||||||
pakb
approved these changes
Mar 27, 2024
since we are working on the time Slider implementation, we might as refactor it with the composition API
PB-318: refactor time slider to composition API
Therefore made the parsing case insensitive.
The removed duplicates logic did not worked as expected and removed all projections from the list which resulted to fallback to WGS84.
Some provider are very slow, like for example the provider for jura.ch takes ~20-25s to download the get capabilities of 1.4MB !
Some provider like canton solothurn use KVP in WMTS instead of REST, those were broken because the get capabilities done by our open layer component did not added the KVP query parameters. Now we use the same code as used in the external catalogue parsing.
This avoid error logs and made the code complete, even though those projections are not used for WMTS layers.
Also removed possible race condition due to the .then() in cypress that don't do retries in opposite of .should()
To avoid to load the get capabilities for each layers, we now save the WMTS options in the layer object. Due to this we need to register the proj4 projection earlier than in the open layer map because the get capabilities are parsed during the startup before openlayer map is loaded.
PB-361: Divers External Layers bug fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link