Merged
Conversation
The new @features param wasn't checking that it was looping over features with layer, creating error when selecting drawing features The geometry of a feature came sometimes directly from the store, and was shallow-cloned only by reproject utils. Vuex was then raising an error because reproject attempted to modify something coming from the store. We now deep-clone the geometry before passing it to reproject
af70330 to
4614a3b
Compare
Passing run #1343 ↗︎
Details:
Review all test suite changes for PR #741 ↗︎ |
|||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new @features param wasn't checking that it was looping over features with layer, creating error when selecting drawing features
The geometry of a feature came sometimes directly from the store, and was shallow-cloned only by reproject utils. Vuex was then raising an error because reproject attempted to modify something coming from the store. We now deep-clone the geometry before passing it to reproject
Test link