PB-318: refactor time slider to composition API#742
Merged
Conversation
Passing run #1357 ↗︎
Details:
Review all test suite changes for PR #742 ↗︎ |
|||||||||||||||
9711063 to
f5867a1
Compare
pakb
approved these changes
Mar 27, 2024
Comment on lines
+161
to
+162
| // we can't watch currentYear and dispatch changes to the store here, otherwise the store gets | ||
| // dispatch too many times when the user is moving the time slider (we wait for mouseup our | ||
| // touchend to commit the change) |
Contributor
There was a problem hiding this comment.
That's good enough, but now that we have some "experience" and some utils to debounce actions, you might want to plan switching to a debounce based store dispatch approach.
Relying on both mouseup and touchend can be a bit tricky on some devices that fire both
Contributor
Author
There was a problem hiding this comment.
My goal was mostly to make a 1 to 1 translation. I'll keep that in mind when I'm developing the new features, especially with the datas that are distinct.
since we are working on the time Slider implementation, we might as refactor it with the composition API
426bff3 to
2aab9ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since we are working on the time Slider implementation, we might as refactor it with the composition API
Test link