PB-324: Show layer info button without legend#734
Merged
Conversation
7b67750 to
a841b0e
Compare
Passing run #1347 ↗︎
Details:
Review all test suite changes for PR #734 ↗︎ |
|||||||||||||||
a841b0e to
98c7531
Compare
LukasJoss
commented
Mar 25, 2024
|
|
||
| const hasChildren = computed(() => item.value?.layers?.length > 0) | ||
| const hasLegend = computed(() => canBeAddedToTheMap.value && item.value?.hasLegend) | ||
| const hasLegend = computed(() => canBeAddedToTheMap.value && item.value?.hasDescription) |
Contributor
Author
There was a problem hiding this comment.
@pakb is hasDescription a good variable name? In that case I should probably update all the variable names which referer to legend instead of description.
Contributor
There was a problem hiding this comment.
I can't think of a better name if we want to keep it short... So let's go with that 😉
fe63e3f to
a258ddb
Compare
pakb
approved these changes
Mar 27, 2024
|
|
||
| const hasChildren = computed(() => item.value?.layers?.length > 0) | ||
| const hasLegend = computed(() => canBeAddedToTheMap.value && item.value?.hasLegend) | ||
| const hasLegend = computed(() => canBeAddedToTheMap.value && item.value?.hasDescription) |
Contributor
There was a problem hiding this comment.
I can't think of a better name if we want to keep it short... So let's go with that 😉
| layer.value.attributions.map((attribution) => attribution.name).join(', ') | ||
| ) | ||
| const showLegendIcon = computed(() => layer.value.hasLegend) | ||
| const showLegendIcon = computed(() => layer.value.hasDescription) |
Contributor
There was a problem hiding this comment.
We could maybe go all the way and rename this to showLayerDescriptionIcon and also rename the LayerLegendPopup to LayerDescriptionPopup so that we are thorough with our renaming
79c526e to
539999a
Compare
LukasJoss
commented
Mar 27, 2024
| * metadata) are still loading. Default is `false` | ||
| * @param {LayerTimeConfig | null} [layerData.timeConfig=null] Time series config (if | ||
| * available). Default is `null` | ||
| * @param {Boolean} [layerData.hasDescription=true] Define if this layer has a description that |
Contributor
Author
There was a problem hiding this comment.
@pakb does there already exist a ticket for this or should this remain hard coded?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link