Conversation
with i18n management
Add page title
Update Cypress to v10, and change config accordingly. Test files for Cypress now have a .cy.js extension (instead of .spec.js) so that they are not confused for unit tests. (See Cypress 10 migration guide for more in depth explanations) Updating any libs possible to newer versions
Remove unwanted typescript lib
Updating libs (and Cypress to v10)
-Moved MeasureManager from DrawingMeasureInteraction.vue to DrawingModule.vue, so that Overlays can also be managed for imported KML layers. -Features from imported KML layers can now also be deleted -New drawabort event, so that overlays are correctly cleared when the drawing is aborted
The Measure Manager moved to utils and also added to OpenLayersKMLLayer so that the Overlays also show up when not in drawing mode.
- test to validate that features from imported KML layers are correctly loaded and can be deleted - test to check that measure overlays are cleared when drawing is aborted
…ditable-when-reopened Bugfix 2410 drawing should be editable when reopened
…n-dev-disclaimer-is-shown App version is only shown when also the dev disclaimer is shown.
…t-startup Focus on search bar at app startup
- KML should now already be saved when the KML Layer is loaded - Measure manager should now correctly remove all overlays handeled by him when the drawing is closed - Correctly set isDrawingEmpty when opening draw mode
- Wait for end of kml update before the drawing is closed - added a loading screen when opening and closing the drawing mode
- To avoid a mismatch between the language of the site and the language of i18n, the language was explicitly assigned to i18n
Comment abortToggleOverlay variable, added the z-indexes in variables.scss, changed the watcher function in DrawingModule to async, and some other minor fixes
also add comments for the use of "this" and "i18n" in a cypress test case.
…-closing-drawing Bugfix 2421 fix kml update when closing drawing
Also hid file extension outside of file api and simplified the triggerdownload function.
- profile.api uses now JSON format to pass the geoJSON, and not the urlencoded format. Fixed the e2e tests accordingly - search.api now does not use anymore a version number in the URL, as this is not supported anymore by sys-api3
…profile-popup Add a link to the service-alti api to download a CSV of the profile data
This is an ADR based on the JIRA ticket. In order to enable users on mobile to also have access to the location popup, we have to think of a way to have 3 features on 2 gestures (touch and long touch). The solution is to always run an "identify" request on short touch, and if nothing is found toggle the fullscreen mode. This frees the long click so that we can use it to show the location popup on mobile too.
…drawing menu styling Some button without icons where using the ButtonWithIcon class and therefore a margin to the label was added putting the text of center. To solve this I made the icon required in the later class and changed all button that don't have an icon to use directly bootstrap. Also align the style of the drawing open/close menu to the one of the regular menu.
The button had a warning and the selection was not kept.
Add some small margin in the time selector.
This button uses the PopOverButton which uses the ButtonWithIcon which had a fixed margin for the text. The issue is that the time selector button has no icon, therefore we don't need any margin. This has been temporarly fixed but we need to refactor the whole application button (see BGDIINF_SB-2680)
Improved look and feel of menu button
so that the CI can still decipher which branch it is running on, and window users can still build the project
so that the build log is not polluted at startup by this, and if this part of the code fail (for some reasons) it is in post-build phase as it should be
Replace UNIX specific script in build pipeline
As we still need to be able to delete a profile, even if empty, I've left the info container and the trash button. Otherwise, if the whole popup was hidden, the user was not able to delete an empty profile anymore. In E2E test : adding a profile mockup function as it is used in 2 different files, and harmonisation of profile mockup usage. Reactivation of tests that now works as intended.
Removing unnecessary event, fix typo
Overhaul of the d3 chart generation made by the profile popup. - Simplification of many aspects of this generation - Regrouping of (mostly) all d3 related functions in a dedicated file - Removal of artifact code from mf-geoadmin3, or simplification of it - All business calculation related to profile are now made in a API class, as other API files are doing There is still some UI glitches to fix with scrollbar appearing on the side on mobile, or sometimes when the profile is updated as empty.
This way, it's way easier to debug them, and change the app code without having to reload the whole test suite (but it requires a little bit of pre-loading for the first test)
Remove unused/doubled min/max elevation Profile is considered having data if it contains at least 2 points (1 was enough before) Adding unit test coverage for basic profile calculation (hiking time is excluded for now...) Switching from old style for loops to filter/map/reduce equivalent in profile calculations Adding a npm target to run unit test in watch mode, easier to debug this way
When the total distance of the profile exceeds 10km, the chart now switches back to display km as values on the X axis instead of flooding the user with big meter numbers
Rename also related components and some variable to reflect this change.
So that we thoroughly test that the max elevation is not necessarily the last point.
…ile_handling BGDIINF_SB-2472 : better handling of empty profile
Do not set the z-index anymore by reordering the layers in the layers array, but by setting the zIndex property of the layer, so the z indicies can be set to anything without having to fear to throw an index out of bounds exception.
…-in-addlayertomap BGDIINF_SB-2660: Fixed index out of bounds exceptions when adding layers
Update libs
and thus going under the base layer while drawing
…ing_layer_zindex BGDIINF_SB-2660 : fix drawing layer not having a zIndex
Contributor
|
One small step for webmapviewer one big for map.geo.admin.ch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link