Conversation
pakb
approved these changes
Nov 15, 2022
Do not set the z-index anymore by reordering the layers in the layers array, but by setting the zIndex property of the layer, so the z indicies can be set to anything without having to fear to throw an index out of bounds exception.
185b0d5 to
2be0b8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not set the z-index anymore by reordering the layers in the layers array, but by setting the zIndex property of the layer, so the z indicies can be set to anything without having to fear to throw an index out of bounds exception.
This new way of definining the z indices has also the advantage that the z indices do not need to follow a strict chronological order anymore. But I haven't tried to simplify this code for the moment.
Test link