Bugfix 2410 drawing should be editable when reopened#227
Merged
Conversation
-Moved MeasureManager from DrawingMeasureInteraction.vue to DrawingModule.vue, so that Overlays can also be managed for imported KML layers. -Features from imported KML layers can now also be deleted -New drawabort event, so that overlays are correctly cleared when the drawing is aborted
The Measure Manager moved to utils and also added to OpenLayersKMLLayer so that the Overlays also show up when not in drawing mode.
pakb
reviewed
Jun 10, 2022
Contributor
pakb
left a comment
There was a problem hiding this comment.
Could you add a test that make sure this is always enabled in the future?
Also I think there's something fishy when editing a marker, I re-edited a KML with a marker and changed its color, and the icon disapeared (it unselected which icon was shown, when I selected another one from the UI it came back)
src/utils/MeasureManager.js
Outdated
Comment on lines
+1
to
+6
| /** | ||
| * Handels the overlays that are shown on top of a each measure drawing | ||
| * | ||
| * It is used in the Drawing module as well as in the map KMLLayer, as the drawing is displayed with | ||
| * a KML Layer when outside of the drawing mode. | ||
| */ |
Contributor
There was a problem hiding this comment.
you can move that a couple lines below (just before the component declaration)
- test to validate that features from imported KML layers are correctly loaded and can be deleted - test to check that measure overlays are cleared when drawing is aborted
1361990 to
cc2483e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was due to a call to the measure manager in the drawing module, in which it was undefined. Tof fix it, the measure manager was moved to the Drawing Layer, so that it can also be called when adding a saved KML Layer. It was also added in the map KML Layer.
Test link