Bugfix 2421 fix kml update when closing drawing#229
Merged
Conversation
6577f62 to
0754573
Compare
Contributor
|
There's a e2e test that fails regarding drawing overlay : That's some weird CSS selector, maybe we should change how an external KML ID is generated... |
daebe25 to
14f3bc5
Compare
pakb
requested changes
Jun 29, 2022
- KML should now already be saved when the KML Layer is loaded - Measure manager should now correctly remove all overlays handeled by him when the drawing is closed - Correctly set isDrawingEmpty when opening draw mode
- Wait for end of kml update before the drawing is closed - added a loading screen when opening and closing the drawing mode
- To avoid a mismatch between the language of the site and the language of i18n, the language was explicitly assigned to i18n
Comment abortToggleOverlay variable, added the z-indexes in variables.scss, changed the watcher function in DrawingModule to async, and some other minor fixes
also add comments for the use of "this" and "i18n" in a cypress test case.
5d980dc to
94757f3
Compare
94757f3 to
6dff9bd
Compare
pakb
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mapviewer should now better handle the closing of the drawing mode. When the drawing mode is leaved, the KML is now saved immediately, so that it is saved before it is loaded. This PR also tries to fix an issue where the Measure Overlays would not be correctly updated when closing the drawing.
Test link