Skip to content

New Release v1.55.2 - #patch#1342

Merged
pakb merged 8 commits intomasterfrom
develop
May 16, 2025
Merged

New Release v1.55.2 - #patch#1342
pakb merged 8 commits intomasterfrom
develop

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented May 16, 2025

pakb added 4 commits May 16, 2025 09:14
It adds an overflow: hidden CSS props to the element being collapsed, breaking any scrollbox we've set up (such as in the menu)

Removing this component for a quick fix, and will create a new (home-made) collapse component/animation to replace it later for the next minor release/version
Some users that use the browser zoom to enlarge the UI have issues with the SimpleWindow component (especially when it's used by the feedback component) because it grows too heigh, and overflow the header (some even saying the X button of the window was out of screen).

So to fix that, I've limited the height of all simple windows to 2/3 of the height of the screen. This was tested with a browser zoom of 200% and having the "report a problem" window opened.
@pakb pakb requested a review from schtibe May 16, 2025 09:43
@github-actions github-actions bot changed the title #patch New Release v1.55.2 - #patch May 16, 2025
@cypress
Copy link

cypress bot commented May 16, 2025

web-mapviewer    Run #5334

Run Properties:  status check passed Passed #5334  •  git commit e68476f38f: Merge pull request #1344 from geoadmin/fix-PB-1257-data-driven-nodata-for-COGs
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #5334
Run duration 05m 32s
Commit git commit e68476f38f: Merge pull request #1344 from geoadmin/fix-PB-1257-data-driven-nodata-for-COGs
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 20
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 251
View all changes introduced in this branch ↗︎

pakb added 4 commits May 16, 2025 12:02
less page reload, as it is what causes the flakiness with the import GPX test (the map doesn't trigger the ready event on the CI for some reason)
let the COG tell us if it has some nodata, and if nothing is found in the header just let it go through without transparency (aka data-driven nodata)

This caused issue when importing COGs such as this one https://s.geo.admin.ch/ahr56lxj9teb (black color from the map was used as no data, meaning labels and lines were rendered transparent)
@pakb pakb merged commit 98e8392 into master May 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants