PB-1257: do not set default value for "nodata" with COGs#1344
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1257-data-driven-nodata-for-COGs
|
| Run status |
|
| Run duration | 05m 21s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
251
|
| View all changes introduced in this branch ↗︎ | |
let the COG tell us if it has some nodata, and if nothing is found in the header just let it go through without transparency (aka data-driven nodata) This caused issue when importing COGs such as this one https://s.geo.admin.ch/ahr56lxj9teb (black color from the map was used as no data, meaning labels and lines were rendered transparent)
e287f6d to
dcb69c5
Compare
schtibe
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let the COG tell us if it has some nodata, and if nothing is found in the header just let it go through without transparency (aka data-driven nodata)
This caused issue when importing COGs such as this one https://s.geo.admin.ch/ahr56lxj9teb (black color from the map was used as no data, meaning labels and lines were rendered transparent)
Test link with COG mentioned above
Test link