PB-1697: limiting floating window's height#1341
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1697-simple-window-too-big-when-broser-zoom
|
| Run status |
|
| Run duration | 05m 13s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
251
|
| View all changes introduced in this branch ↗︎ | |
Base automatically changed from
fix-PB-1698-scroll-issue-with-new-collapse-component
to
develop
May 16, 2025 08:58
12b65bd to
ca66776
Compare
Some users that use the browser zoom to enlarge the UI have issues with the SimpleWindow component (especially when it's used by the feedback component) because it grows too heigh, and overflow the header (some even saying the X button of the window was out of screen). So to fix that, I've limited the height of all simple windows to 2/3 of the height of the screen. This was tested with a browser zoom of 200% and having the "report a problem" window opened.
ca66776 to
0f93527
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users that use the browser zoom to enlarge the UI have issues with the SimpleWindow component (especially when it's used by the feedback component) because it grows too high, and overflow the header (some even saying the X button of the window was out of screen).
So to fix that, I've limited the height of all simple windows to 2/3 of the height of the screen. This was tested with a browser zoom of 200% and having the "report a problem" window opened.
Test link