PB-1698: fix scroll issue with new collapse component#1340
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1698-scroll-issue-with-new-collapse-component
|
| Run status |
|
| Run duration | 05m 28s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
251
|
| View all changes introduced in this branch ↗︎ | |
618e0ce to
0d767a5
Compare
It adds an overflow: hidden CSS props to the element being collapsed, breaking any scrollbox we've set up (such as in the menu) Removing this component for a quick fix, and will create a new (home-made) collapse component/animation to replace it later for the next minor release/version
0d767a5 to
33f82ef
Compare
schtibe
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds an overflow: hidden CSS props to the element being collapsed, breaking any scrollbox we've set up (such as in the menu)
Removing this component for a quick fix, and will create a new (home-made) collapse component/animation to replace it later for the next minor release/version
Test link