selective newsletter for space admins#3
Merged
isaacmg410 merged 7 commits intoselective_newsletterfrom Apr 29, 2019
Merged
Conversation
isaacmg410
reviewed
Apr 26, 2019
isaacmg410
left a comment
There was a problem hiding this comment.
@agustibr good job!
@tramuntanal we are waiting your review :)
tramuntanal
requested changes
Apr 26, 2019
Collaborator
tramuntanal
left a comment
There was a problem hiding this comment.
Simple solution 👍 I thought it would be harder. Great job @agustibr!
Just some readability improvements
decidim-assemblies/app/queries/decidim/assemblies/admin/admin_users.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/app/queries/decidim/conferences/admin/admin_users.rb
Outdated
Show resolved
Hide resolved
Author
|
Thanks for the review and the suggestions @tramuntanal 😃 |
113106f to
bc0317c
Compare
Author
|
@tramuntanal all checks green! ✔️ ✔️ |
|
@tramuntanal Can this PR be merged? The changes you have requested have been applied? If so, can you approve the PR? |
tramuntanal
requested changes
Apr 29, 2019
| .participatory_spaces.call(current_organization)&.published&.order(title: :asc) | ||
| end | ||
|
|
||
| def spaces_user_can_admin |
Collaborator
There was a problem hiding this comment.
is this method returning spaces_user_can_admin_as_options_for_select?
Author
There was a problem hiding this comment.
Returns the structure for the select, used in:
decidim/decidim-admin/app/helpers/decidim/admin/newsletters_helper.rb
Lines 36 to 41 in c00248d
but it's also used to check which spaces the user can manage:
decidim/decidim-admin/app/helpers/decidim/admin/newsletters_helper.rb
Lines 15 to 16 in c00248d
| @spaces_user_can_admin | ||
| end | ||
|
|
||
| def space_datum(space) |
Collaborator
There was a problem hiding this comment.
space_as_options_for_select?
agustibr
pushed a commit
that referenced
this pull request
Apr 30, 2019
* initial commit selective newsletter * working on queries recipients * working on queries * improve view * start querying scopes * send newsletter to users, pending filter participants * some new improvements on selective newsletter * initial queries filtering participants * run rubocop to fix offenses * remove unnecessary css * change no_recipients and recipients_query * adding some translations * add some translations * extract participants code to each module * add class to select option * fix lint errors * fix rubocop offenses * missing locales and fix i18n specs * add documentation * add changelog line * remove unnecessary comma * working specs * wip working on specs * fix offenses * fix rubocop lambda * working with specs newsletter * improve specs query * fix rubocop on decidim dev * improve specs * add newsletters js to manifest and fix newsletter helper * change translation from any to none * selective newsletter for space admins (#3) * selective newsletter for space admins * refactor space_allows_admin_access? to be more performant * improve spaces_user_can_admin memoization * update CHANGELOG entry * renamed admin_newsletter_action? to apply_newsletter_permissions_for_admin! * update (space)_user_admins return user objects not ids * rename Decidim::Admin::NewslettersHelper#space_datum to :space_as_option_for_select * fix rubocop offense * A space admin can't send to all users * add space admin user examples to deliver_newsletter_spec * remove comments
tramuntanal
pushed a commit
that referenced
this pull request
Feb 10, 2021
* revert keys type in smtp_settings from symbol to strings * switch smtp_settings keys from symbols to strings * Fix smtp settings specs (#2) * light cleanup application mailer specs * add tests in register organization specs * Revert "Fix smtp settings specs (#2)" (#3) This reverts commit 9838bec. * Update organization seeds (#1) * Update organization seeds * Fix migration * Clean tests * Complete migration by adding down * Fix smtp settings specs (#4) * light cleanup application mailer specs * add tests in register organization specs * Remove migration and update CHANGELOG * Remove CHANGELOG entry Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com> Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Adds the ability of sending (selective) newsletters to space admins.
📌 Related Issues