Merged
Conversation
1f95bd3 to
4095354
Compare
Contributor
Author
|
@decidim/lot-core it's still work in progress, specs are missing, but if you can make a first review and give your opinion, it will be very helpful. 😄 |
mrcasals
reviewed
Apr 4, 2019
decidim-admin/app/forms/decidim/admin/selective_newsletter_form.rb
Outdated
Show resolved
Hide resolved
mrcasals
reviewed
Apr 4, 2019
mrcasals
reviewed
Apr 4, 2019
Contributor
|
@isaacmg410 I did a quick review and code looks good! |
cd528e2 to
e3f469a
Compare
Contributor
Author
|
@decidim/lot-core ready to review |
Contributor
|
@isaacmg410 tests are failing, can you check them? |
c7f41e8 to
ab28a84
Compare
Contributor
|
@mrcasals Fixed failing checks, now all checks are green 😄 |
Contributor
Author
|
Thanks a lot @agustibr! |
Contributor
Author
|
Hey @decidim/lot-core! All checks are green and ready to review! Thanks! |
added 7 commits
April 24, 2019 13:12
ab28a84 to
b5d51d5
Compare
* selective newsletter for space admins * refactor space_allows_admin_access? to be more performant * improve spaces_user_can_admin memoization * update CHANGELOG entry * renamed admin_newsletter_action? to apply_newsletter_permissions_for_admin! * update (space)_user_admins return user objects not ids * rename Decidim::Admin::NewslettersHelper#space_datum to :space_as_option_for_select
11f3567 to
71e52cf
Compare
oriolgual
suggested changes
Apr 30, 2019
Contributor
oriolgual
left a comment
There was a problem hiding this comment.
Nice job, just two minor changes!
3 tasks
2 tasks
11 tasks
12 tasks
12 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR addresses the need to segment the sending of newsletters whether users become followers or Participants of a ParticipatorySpace.
You want to be able to send newsletters according to the participation or the interest of the users.
The idea is to extend the functionality that already begins to have Decidim of selection of interests and Allow newsletters segmented for participants and scopes.
📌 Related Issues
📋 Subtasks
CHANGELOGentryAdd/modify seeds📷 Screenshots (optional)