Fix smtp_settings keys type#6908
Merged
tramuntanal merged 10 commits intodecidim:developfrom Nov 25, 2020
Merged
Conversation
sauloperez
previously approved these changes
Nov 20, 2020
Contributor
Author
|
Hi @sauloperez! thanks for the review, I'm currently adding tests in |
sauloperez
added a commit
to CoopCat-Confederacio-de-Cooperatives/decidim-coopcat
that referenced
this pull request
Nov 20, 2020
There's a fix in decidim/decidim#6908 for the regression introduced in decidim/decidim#6664, but its revert done in decidim/decidim#6905 is not merged either. We can't wait any longer so I'm doing the revert myself.
* light cleanup application mailer specs * add tests in register organization specs
* Update organization seeds * Fix migration
* light cleanup application mailer specs * add tests in register organization specs
Contributor
|
Re-running admin and proposals workflows that got stuck |
tramuntanal
suggested changes
Nov 23, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
@Dynnammo can you check my comment ?
decidim-system/db/migrate/20201120160614_fill_smtp_from_email.rb
Outdated
Show resolved
Hide resolved
tramuntanal
suggested changes
Nov 24, 2020
tramuntanal
approved these changes
Nov 24, 2020
Contributor
|
@Dynnammo can you proceed with the backports please? |
This was referenced Nov 24, 2020
davidbeig
pushed a commit
to CoopCat-Confederacio-de-Cooperatives/decidim-coopcat
that referenced
this pull request
Dec 2, 2025
There's a fix in decidim/decidim#6908 for the regression introduced in decidim/decidim#6664, but its revert done in decidim/decidim#6905 is not merged either. We can't wait any longer so I'm doing the revert myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Correct the regression introduced in a PR I made previously : #6664
While @Quentinchampenois is making a revert here #6905 and here #6904 for the releases that are affected, this correction aims to correct regressions introduced, while keeping corrections made in #6664 (which are the correct setup of
fromandfrom_emailfield), in order not to fall back on the previous situation📌 Related Issues
Link your PR to an issue
Testing
Should need a production environment to correctly test the email sending with the modification of all parameters in the
set_smtpmethod📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
