Backport 'Correct smtp_settings keys type #6908' on release/0.23-stable#6904
Merged
tramuntanal merged 2 commits intodecidim:release/0.23-stablefrom Nov 25, 2020
Conversation
This was referenced Nov 20, 2020
* Revert for backport This reverts commit 0757303. * Backport 'Correct smtp_settings keys type'
tramuntanal
approved these changes
Nov 25, 2020
Contributor
|
Merging as the erb-linter error is not related with this PR and it doesn't change any erb file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 73bd3d1.
🎩 What? Why?
I apologize for this reverted backport proposition, we noticed just this morning a smtp settings issue introduced by #6664
UPDATE
This PR is no longer a revert but a backport of fixes added in #6908
📌 Related Issues
🚨 Migration
In this PR I revert completely the commit, however there is a migration removed (cf:
decidim-system/db/migrate/20201013132945_update_smtp_from_label.rb), do you think it is the best choice to remove this migration ?