Skip to content

Backport 'backport smtp settings correction' on release/0.23-stable#6877

Merged
tramuntanal merged 1 commit intodecidim:release/0.23-stablefrom
Quentinchampenois:backport/smtp-settings-correction-0.23
Nov 19, 2020
Merged

Backport 'backport smtp settings correction' on release/0.23-stable#6877
tramuntanal merged 1 commit intodecidim:release/0.23-stablefrom
Quentinchampenois:backport/smtp-settings-correction-0.23

Conversation

@Quentinchampenois
Copy link
Copy Markdown
Contributor

@Quentinchampenois Quentinchampenois commented Nov 17, 2020 •
edited
Loading

🎩 What? Why?

This PR is a backport proposition of #6664 on the release/0.23-stable branch. It aims to fix smtp settings bug.

Furthermore, I plan to propose another backport of the #6664 on the release/0.22-stable.

📌 Related Issues

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@Quentinchampenois Quentinchampenois mentioned this pull request Nov 17, 2020
Merged
12 tasks
@Quentinchampenois Quentinchampenois marked this pull request as ready for review November 17, 2020 15:43
@virgile-dev
Copy link
Copy Markdown
Contributor

virgile-dev commented Nov 18, 2020

@microstudi @tramuntanal can you guys review this please ? Thanks in advance 🙏

1 similar comment
@virgile-dev
Copy link
Copy Markdown
Contributor

virgile-dev commented Nov 18, 2020

@microstudi @tramuntanal can you guys review this please ? Thanks in advance 🙏

@tramuntanal tramuntanal merged commit 73bd3d1 into decidim:release/0.23-stable Nov 19, 2020
Quentinchampenois added a commit to Quentinchampenois/decidim that referenced this pull request Nov 20, 2020
@Quentinchampenois
Revert "Backport 'backport smtp settings correction' to 0.23 (decidim…
0757303 
…#6877)"

This reverts commit 73bd3d1.
@Dynnammo Dynnammo mentioned this pull request Nov 20, 2020
Closed
This was referenced Nov 20, 2020
Merged
Merged
tramuntanal pushed a commit that referenced this pull request Nov 25, 2020
@Quentinchampenois
Backport 'Correct smtp_settings keys type #6908' on release/0.23-stab…
f117675 
…le (#6904)

* Revert "Backport 'backport smtp settings correction' to 0.23 (#6877)"

This reverts commit 73bd3d1.

* Backport 'Correct smtp_settings keys type' on release/0.23 stable

* Revert for backport

This reverts commit 0757303.

* Backport 'Correct smtp_settings keys type'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tramuntanal tramuntanal tramuntanal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Quentinchampenois @virgile-dev @tramuntanal