Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
This allows the src/python_pybind11/CMakeLists.txt file to be built as a top-level cmake project against an external gz-math library, with documentation added to the installation tutorial. The logic for finding pybind11 is also moved from the root CMakeLists.txt to src/python_pybind11/CMakeLists.txt to reduce code duplication. When invoked through the root CMakeLists.txt, pybind11 is treated as an optional dependency, but when invoked from the src/python_pybind11 folder, pybind11 is treated it as required by setting CMAKE_REQUIRE_FIND_PACKAGE_pybind11 to TRUE. Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Silvio Traversaro <silvio.traversaro@iit.it>
Backport of #636 with adapted package finding logic and a note about requiring cmake 3.22.1. This allows the src/python_pybind11/CMakeLists.txt file to be built as a top-level cmake project against an external gz-math library, with documentation added to the installation tutorial. The logic for finding pybind11 is also moved from the root CMakeLists.txt to src/python_pybind11/CMakeLists.txt to reduce code duplication. When invoked through the root CMakeLists.txt, pybind11 is treated as an optional dependency, but when invoked from the src/python_pybind11 folder, pybind11 is treated it as required by setting CMAKE_REQUIRE_FIND_PACKAGE_pybind11 to TRUE. Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Silvio Traversaro <silvio.traversaro@iit.it> (cherry picked from commit 17deea2)
Merge gz-math7 ➡️ gz-math8
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Requires gz-cmake4 4.1.0. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
* add Config to Color as dep * Add Config to Angle * Add AxisAlignedBox dep * Add more missing deps * fix BUILD file with buildifier Signed-off-by: Udaya Prakash <udayaprakash2899@gmail.com> Signed-off-by: udayaprakash <udayaprakash@google.com>
* Enable parse_headers and process_headers_in_dependencies checks for bazel build Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Enable layering checks for gz-math/eigen3 Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> --------- Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Michael Carroll <carroll.michael@gmail.com> Co-authored-by: Shameek Ganguly <shameek@intrinsic.ai>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Encapsulate std::cerr under a single point of control When integrating this library into a larger application, downstream code doesn't always want to spew onto cerr. To allow customization, we'll refactor to encapsulate the destination inside of a function. Future work can extent this with a mechanism to redirect it (e.g., to send it to spdlog instead of cerr). --------- Signed-off-by: Jeremy Nimmer <jeremy.nimmer@tri.global>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
The value of this variable may change if other code paths call find_package(Python3), so move the warning to be co-located with the add_subdirectory call. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Prepare for 8.1.1 release Signed-off-by: Carlos Agüero <caguero@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: anshium <anshchablani@gmail.com>
Part of gazebo-tooling/release-tools#1288 Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Signed-off-by: Gabriel Augusto <95982237+gabrielaugz@users.noreply.github.com> Co-authored-by: gabrielaugz <wornbr22p@outlook.com>
The ability to build python bindings separately from the core library was added in #636 and is currently used when building the homebrew formulae but is not directly tested in CI. This adds a quick test to the Ubuntu GitHub actions workflow to compile the python bindings after compiling example code. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
I think that we are affected by bazelbuild/bazel-central-registry#4355 |
j-rivero
left a comment
There was a problem hiding this comment.
I think I've fixed the Bazel build
thanks! I'm going to try cherry-picking that back to gz-math8 and then I'll amend this merge branch |
|
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com> Co-authored-by: Jose Luis Rivero <jrivero@honurobotics.com>
* Fix import in AxisAlignedBoxHelpers_TEST.py * BUILD.bazel: fix version Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
b6bcf9f to
1f17c4a
Compare
|
@scpeters the failure on windows is happening on gz-math-main-clnwin jobs. See: https://build.osrfoundation.org/job/gz_math-pr-cnlwin/8/ Would this be fixed by any PR that hasn't been merged? Or does it need a different PR to fix it? |
|
It will be fixed by #677 We merged the supporting homebrew-simulation and gazebodistro PRs a little early, best to wait and merge them all together |
➡️ Forward port
Port
gz-math8➡️mainBranch comparison: main...gz-math8
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)