Add missing dependencies to targets#644
Merged
mjcarroll merged 6 commits intogazebosim:gz-math8from Nov 15, 2024
Merged
Conversation
Signed-off-by: Udaya Prakash <udayaprakash2899@gmail.com>
Signed-off-by: Udaya Prakash <udayaprakash2899@gmail.com>
Signed-off-by: Udaya Prakash <udayaprakash2899@gmail.com>
Signed-off-by: Udaya Prakash <udayaprakash2899@gmail.com>
Contributor
|
@mjcarroll / @shameekganguly is there a reason CI is not catching missing dependencies? |
Contributor
Author
|
My hunch is that it doesn't actually evaluate those headers used in the .hh files. Why this is happening is out of my reach. |
The only thing that would probably exercise this is the unit tests, which probably either also include the same headers or get the transitively somehow. |
mjcarroll
approved these changes
Nov 14, 2024
mjcarroll
reviewed
Nov 14, 2024
Signed-off-by: udayaprakash <udayaprakash@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Fixes missing Bazel dependencies to make gz-math work with bzlmod
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.